Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙈 Exclude Cooker From Nuke #8702

Merged
merged 4 commits into from
Dec 6, 2024
Merged

🙈 Exclude Cooker From Nuke #8702

merged 4 commits into from
Dec 6, 2024

Conversation

connormaglynn
Copy link
Contributor

@connormaglynn connormaglynn commented Dec 6, 2024

A reference to the issue / Description of it

MoJ Read Team will be using this account temporarily, so we don't want to destroy the resources in this account

How does this PR fix the problem?

Excludes cooker from the Nuke job

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

NA

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

NA

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

NA

@connormaglynn connormaglynn requested a review from a team as a code owner December 6, 2024 15:50
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

@github-actions github-actions bot added the onboarding Tasks to onboard teams label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

ewastempel
ewastempel previously approved these changes Dec 6, 2024
Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@connormaglynn connormaglynn added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 95bc484 Dec 6, 2024
27 checks passed
@connormaglynn connormaglynn deleted the exlcude-cooker-from-nuke branch December 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants