Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPR2-1553: Grant dms:ModifyReplicationInstance to DPR circle_ci #8675

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

koladeadewuyi-moj
Copy link
Contributor

@koladeadewuyi-moj koladeadewuyi-moj commented Dec 4, 2024

A reference to the issue / Description of it

The digital prisons reporting circle_ci role needs to be able to modify DMS instances e.g. when performing an upgrade.

How does this PR fix the problem?

This PR grants dms:ModifyReplicationInstance to the circle_ci role

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

N/A

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

None

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/digital-prison-reporting


Running Trivy in terraform/environments/digital-prison-reporting
2024-12-04T12:01:57Z INFO [vulndb] Need to update DB
2024-12-04T12:01:57Z INFO [vulndb] Downloading vulnerability DB...
2024-12-04T12:01:57Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-04T12:02:00Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-04T12:02:00Z INFO [vuln] Vulnerability scanning is enabled
2024-12-04T12:02:00Z INFO [misconfig] Misconfiguration scanning is enabled
2024-12-04T12:02:00Z INFO [misconfig] Need to update the built-in checks
2024-12-04T12:02:00Z INFO [misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-12-04T12:02:02Z INFO [secret] Secret scanning is enabled
2024-12-04T12:02:02Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-12-04T12:02:02Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.58/docs/scanner/secret#recommendation for faster secret detection
2024-12-04T12:02:03Z INFO [terraform scanner] Scanning root module file_path="."
2024-12-04T12:02:03Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-12-04T12:02:03Z INFO Number of language-specific files num=0
2024-12-04T12:02:03Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/digital-prison-reporting

*****************************

Running Checkov in terraform/environments/digital-prison-reporting
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 19, Failed checks: 0, Skipped checks: 5


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/digital-prison-reporting

*****************************

Running tflint in terraform/environments/digital-prison-reporting
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/digital-prison-reporting

*****************************

Running Trivy in terraform/environments/digital-prison-reporting
2024-12-04T12:01:57Z	INFO	[vulndb] Need to update DB
2024-12-04T12:01:57Z	INFO	[vulndb] Downloading vulnerability DB...
2024-12-04T12:01:57Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-04T12:02:00Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-04T12:02:00Z	INFO	[vuln] Vulnerability scanning is enabled
2024-12-04T12:02:00Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-12-04T12:02:00Z	INFO	[misconfig] Need to update the built-in checks
2024-12-04T12:02:00Z	INFO	[misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-12-04T12:02:02Z	INFO	[secret] Secret scanning is enabled
2024-12-04T12:02:02Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-12-04T12:02:02Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.58/docs/scanner/secret#recommendation for faster secret detection
2024-12-04T12:02:03Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-12-04T12:02:03Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-12-04T12:02:03Z	INFO	Number of language-specific files	num=0
2024-12-04T12:02:03Z	INFO	Detected config files	num=2
trivy_exitcode=0

Copy link
Contributor

@Khatraf Khatraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koladeadewuyi-moj koladeadewuyi-moj added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 2e9c04f Dec 4, 2024
20 checks passed
@koladeadewuyi-moj koladeadewuyi-moj deleted the DPR2-1553 branch December 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants