Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Docs/cost metrics per account #8467

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

ASTRobinson
Copy link
Contributor

A reference to the issue / Description of it

Documentation for #7170

How does this PR fix the problem?

Updates cost metrics documentation for per account_id functionality

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

locally tested in vscode.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No - Documentation only.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@ASTRobinson ASTRobinson requested a review from a team as a code owner November 12, 2024 13:05
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - love the animated images!

@ASTRobinson ASTRobinson added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit ad4b766 Nov 12, 2024
5 checks passed
@ASTRobinson ASTRobinson deleted the docs/cost-metrics-per-account branch November 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants