Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to pd status page doc #8453

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

richgreen-moj
Copy link
Contributor

A reference to the issue / Description of it

Review of docs required: https://mojdt.slack.com/archives/C013RM6MFFW/p1731058243266799

How does this PR fix the problem?

A few minor adjustments to the PD Status Page doc

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj marked this pull request as ready for review November 8, 2024 10:35
@richgreen-moj richgreen-moj requested a review from a team as a code owner November 8, 2024 10:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@richgreen-moj richgreen-moj added this pull request to the merge queue Nov 8, 2024
Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ASTRobinson ASTRobinson removed this pull request from the merge queue due to the queue being cleared Nov 8, 2024
@ASTRobinson ASTRobinson merged commit 80b1208 into main Nov 8, 2024
5 checks passed
@ASTRobinson ASTRobinson deleted the docs/daniel-updates-081124 branch November 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants