Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New runbook documentation #8297

Merged
merged 2 commits into from
Oct 21, 2024
Merged

New runbook documentation #8297

merged 2 commits into from
Oct 21, 2024

Conversation

markgov
Copy link
Contributor

@markgov markgov commented Oct 21, 2024

A reference to the issue / Description of it

This Pr updated the new account documentation with the information about the new tag implemented in the JSON environment files

How does this PR fix the problem?

Adds in a paragraph on critical-national-infrastructure tag

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@markgov markgov requested a review from a team as a code owner October 21, 2024 15:03
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 21, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

In a recent update to the JSON environment file we have added a new tag called critical-national-infastructure, this tag to to help us report on
vital applications and infrastructure to the ministry of justice. This is a boolean input and the default is always false but if your application is critical then this should be set to true.

See [#8191](https://github.com/ministryofjustice/modernisation-platform/pull/8191) for an example of the change required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to just the commit? Ive been told thats better I cant remember why though..

@@ -78,6 +78,11 @@ In this example, only the `modernisation-platform` team can approve the Github a

See [#6338](https://github.com/ministryofjustice/modernisation-platform/pull/6338) for an example of the change required.

In a recent update to the JSON environment file we have added a new tag called critical-national-infastructure, this tag to to help us report on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tag exists to to help us report on

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@markgov markgov added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit db214ba Oct 21, 2024
5 checks passed
@markgov markgov deleted the docs/update-new-account-creation branch October 21, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants