Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing-test secrets to baselines module repo #7301

Closed
wants to merge 1 commit into from

Conversation

richgreen-moj
Copy link
Contributor

A reference to the issue / Description of it

#6490

How does this PR fix the problem?

I need to add the testing-test keys to the baselines repository to facilitate unit testing via a GitHub action

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj requested a review from a team as a code owner June 21, 2024 10:18
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/github


Running Trivy in terraform/github
2024-06-21T10:20:55Z INFO Need to update DB
2024-06-21T10:20:55Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T10:20:57Z INFO Vulnerability scanning is enabled
2024-06-21T10:20:57Z INFO Misconfiguration scanning is enabled
2024-06-21T10:20:57Z INFO Need to update the built-in policies
2024-06-21T10:20:57Z INFO Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T10:20:57Z INFO Secret scanning is enabled
2024-06-21T10:20:57Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T10:20:57Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T10:21:00Z INFO Number of language-specific files num=0
2024-06-21T10:21:00Z INFO Detected config files num=3

modules/repository/main.tf (terraform)

Tests: 42 (SUCCESSES: 14, FAILURES: 0, EXCEPTIONS: 28)
Failures: 0 (HIGH: 0, CRITICAL: 0)

testing-ci.tf (terraform)

Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/github

*****************************

Running Checkov in terraform/github
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 95, Failed checks: 0, Skipped checks: 99


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/github

*****************************

Running tflint in terraform/github
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/github

*****************************

Running Trivy in terraform/github
2024-06-21T10:20:55Z	INFO	Need to update DB
2024-06-21T10:20:55Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-21T10:20:57Z	INFO	Vulnerability scanning is enabled
2024-06-21T10:20:57Z	INFO	Misconfiguration scanning is enabled
2024-06-21T10:20:57Z	INFO	Need to update the built-in policies
2024-06-21T10:20:57Z	INFO	Downloading the built-in policies...
53.79 KiB / 53.79 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-21T10:20:57Z	INFO	Secret scanning is enabled
2024-06-21T10:20:57Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-21T10:20:57Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-21T10:21:00Z	INFO	Number of language-specific files	num=0
2024-06-21T10:21:00Z	INFO	Detected config files	num=3

modules/repository/main.tf (terraform)
======================================
Tests: 42 (SUCCESSES: 14, FAILURES: 0, EXCEPTIONS: 28)
Failures: 0 (HIGH: 0, CRITICAL: 0)


testing-ci.tf (terraform)
=========================
Tests: 1 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@dms1981 dms1981 deleted the add-testing-secrets-to-baselines-repo branch July 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant