Removed pinned provider version & increased max_retries for Secure Baselines

[richgreen-moj]

A reference to the issue / Description of it

#6486

How does this PR fix the problem?

I've reverted the code that was pinning the version of the AWS TF provider back to v5.38.0

The jobs are now picking up the latest version v5.42.0 which has had an update that stops client side rate limiting which stops you getting the original error we encountered e.g.
failed to get rate limit token, retry quota exceeded, 3 available, 5 requested

But we were still encountering this error e.g.
ListTagsForResource, exceeded maximum number of attempts, 25, https response error StatusCode: 400, RequestID: c17f1153-756e-4968-bd57-e38a51792366, api error ThrottlingException: Rate exceeded

There is an optional max_retries setting that can be applied to the provider so you can raise it from the default of 25.
In this PR I have set it to 100 which has been tested successfully on two subsequent runs of the scheduled baseline job.

How has this been tested?

It worked ... https://github.com/ministryofjustice/modernisation-platform/actions/runs/8422101284

twice... https://github.com/ministryofjustice/modernisation-platform/actions/runs/8422873826

Checklist (check x in [ ] of list items)

• I have performed a self-review of my own code
• All checks have passed

Additional comments (if any)

This might just be a setting we keep our eye on over time as with all the scheduled baseline code which is growing as the platform grows.

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:

[github-actions]

Trivy Scan Success

Show Output

```hcl

---

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output

*****************************

Trivy will check the following folders:

[mikereiddigital]

lg2m