Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added google analytics #6404

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Added google analytics #6404

merged 1 commit into from
Mar 5, 2024

Conversation

ep-93
Copy link
Contributor

@ep-93 ep-93 commented Mar 5, 2024

A reference to the issue / Description of it

For this ticket - #6398

How does this PR fix the problem?

Adds to all pages.

How has this been tested?

It worked here - https://github.com/ministryofjustice/modernisation-platform/pull/6385/files

Deployment Plan / Instructions

Checklist (check x in [ ] of list items)

  • [ x] I have performed a self-review of my own code
  • [ x] All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

@ep-93 ep-93 requested a review from a team as a code owner March 5, 2024 14:59
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@SteveLinden SteveLinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on slack chat

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@ep-93 ep-93 merged commit 1b0b58f into main Mar 5, 2024
5 checks passed
@ep-93 ep-93 deleted the feature/google-analytics branch March 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants