Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug in the powerbi sso assignment #6146

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ewastempel
Copy link
Contributor

@ewastempel ewastempel commented Feb 6, 2024

A reference to the issue / Description of it

See slack thread here: https://mojdt.slack.com/archives/C013RM6MFFW/p1707225725037789

How does this PR fix the problem?

The returned output is already an arn, this PR is to correct the path to it.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

This has been run locally for sprinkler.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

This will be deployed to all environments.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@ewastempel ewastempel merged commit dc3851a into main Feb 6, 2024
13 checks passed
@ewastempel ewastempel deleted the fix-powerbi-sso-assignment branch February 6, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants