Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply secrets KMS CMK encryption #6083

Closed
wants to merge 2 commits into from
Closed

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 30, 2024

A reference to the issue / Description of it

#4999

How does this PR fix the problem?

We have previously excluded the encryption of AWS Secretsmanager secrets from secure code analysis checks around the use of CMKs instead of AWS-managed keys. This PR applies appropriate KMS encryption and creates a KMS key in preparation for further encryption of secrets in the main Modernisation Platform account.

How has this been tested?

No. However $business-unit-general keys are in use within customer business units, and the pagerduty key is also in use (somewhat inconsistently) within the PagerDuty terraform.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

Only if the KMS policies are insufficient. In this case, access to secrets may be interrupted while the policies are amended.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

…on in customer accounts, pagerduty key for pagerduty secrets, created new kms key and policy in MP account
@dms1981 dms1981 requested a review from a team as a code owner January 30, 2024 15:44
@dms1981
Copy link
Contributor Author

dms1981 commented Jan 31, 2024

Closing this PR and breaking it into smaller steps.

@dms1981 dms1981 closed this Jan 31, 2024
@dms1981 dms1981 deleted the feature/4999-secret-encryption branch February 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant