Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference to the issue / Description of it
#4999
How does this PR fix the problem?
We have previously excluded the encryption of AWS Secretsmanager secrets from secure code analysis checks around the use of CMKs instead of AWS-managed keys. This PR applies appropriate KMS encryption and creates a KMS key in preparation for further encryption of secrets in the main Modernisation Platform account.
How has this been tested?
No. However
$business-unit-general
keys are in use within customer business units, and the pagerduty key is also in use (somewhat inconsistently) within the PagerDuty terraform.Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
Only if the KMS policies are insufficient. In this case, access to secrets may be interrupted while the policies are amended.
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}