Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow directory management permission set to start SSM connections #5943

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 10, 2024

A reference to the issue / Description of it

Users who make use of the directory management role need SSM permissions to connect to a directory service management instance.

How does this PR fix the problem?

Adds ssm:* to permissions for role policy.

How has this been tested?

Observed failure when attempting to connect to management instance:

An error occurred while calling the StartConnection API operation. AccessDeniedException: An error occurred (AccessDeniedException) when calling the StartSession operation: User: arn:aws:sts::000000000000:assumed-role/AWSReservedSSO_mp-active-directory-management_93c9c1890364ab9b/user@digital.justice.gov.uk is not authorized to perform: ssm:StartSession on resource: arn:aws:ec2:eu-west-2:000000000000:instance/i-028fd3a3be2530136 because no identity-based policy allows the ssm:StartSession action

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

Deploy through GitHub Actions scheduled baseline

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

Copy link
Contributor

@markgov markgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 merged commit 9d3be86 into main Jan 10, 2024
13 checks passed
@dms1981 dms1981 deleted the feature/active-directory-management-permissions branch January 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants