Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ECR delete scope #5806

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Reduce ECR delete scope #5806

merged 1 commit into from
Dec 14, 2023

Conversation

davidkelliott
Copy link
Contributor

@davidkelliott davidkelliott commented Dec 14, 2023

A reference to the issue / Description of it

Wrong permissions for deleting ECR images

How does this PR fix the problem?

This should be to allow users to delete images, rather than repositories.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

TF Plan

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No (unless people are manually deleting ECR repos which they shouldn't be)

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

This should be to allow users to delete images, rather than repositories.
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@davidkelliott davidkelliott merged commit 7089ea6 into main Dec 14, 2023
13 checks passed
@davidkelliott davidkelliott deleted the bug/ecr-image-deletion-scope branch December 14, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants