Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating SNS topics and updating IAM policy for instance scheduler #5679

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ewastempel
Copy link
Contributor

@ewastempel ewastempel commented Dec 4, 2023

A reference to the issue / Description of it

This PR partially implements the issue 2722.
This is to allow the instance scheduler lambda function to publish to SNS topics and to create topics that the lambda is going to use as the destination config. This is also integrating with an existing pagerduty service.

How does this PR fix the problem?

This is to enable alerts when the instance scheduler fails/succeeds.

How has this been tested?

Run the tf plan locally and it works as expected for the added functionality, but it fails for a transit gateway policy saying it needs an apply. Not end-to-end tested yet, as the lambda terraform module needs updating first.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

The instance scheduler IAM policy may be impacted if configured incorrectly.
SNS topics and the pagerduty integration are new resources, so it does not break the existing functionality.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@ewastempel ewastempel requested a review from a team as a code owner December 4, 2023 17:29
@github-actions github-actions bot added the core label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ewastempel ewastempel merged commit cb5b1d3 into main Dec 5, 2023
7 checks passed
@ewastempel ewastempel deleted the feature-2722-instance-scheduler-alerts branch December 5, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants