generated from ministryofjustice/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub member environments Plan feature #5551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
ASTRobinson
changed the title
test preview payload and updated workflow
GitHub member environments Plan feature
Nov 23, 2023
SteveLinden
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Nov 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference to the issue / Description of it
As per ticket #5363 this PR updates the
terraform-github.yml
workflow to add a 'plan' to thecreate-github-environments
job. This job passes through adry_run
flag which in turn omits the GitHub API submissionHow does this PR fix the problem?
This change will ensure that API submissions will only be applied when changes are merged into
main
How has this been tested?
I have tested that changes are not submitted to the API when a pull request is raised. Once this PR is merged I will raise a small change to ensure changes are still being applied correctly on merge to
main
.Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
This PR should have no impact on the platform or services.
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}