Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firewall rules for DPAT to DOM1 (development) #5472

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ASTRobinson
Copy link
Contributor

@ASTRobinson ASTRobinson commented Nov 14, 2023

A reference to the issue / Description of it

Slack request here: https://mojdt.slack.com/archives/C01A7QK5VM1/p1699975122396359

How does this PR fix the problem?

This PR adds firewall rules from Data Platform Apps and Tools to DOM1 NAS filer for ports 445 & 389

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

All automated testes have completed successfully

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No this PR only adds additional rules and will not impact any services.

Checklist (check x in [ ] of list items)

  • [ X ] I have performed a self-review of my own code
  • [ X ] All checks have passed

Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson ASTRobinson merged commit 813e781 into main Nov 15, 2023
7 checks passed
@ASTRobinson ASTRobinson deleted the feature/add_firewall_dpat_to_dom1 branch November 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants