Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssm:TerminateSession action to OIDC role policy #5402

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

andrewmooreio
Copy link
Contributor

A follow-up to the previous PR to add various permissions to allow SSH over SSM for our GitHub Workflows:
#5384

The session can be established, however it cannot close cleanly without the ssm:TerminateSession action permission. Adding it back in.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Copy link
Contributor

@markgov markgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewmooreio andrewmooreio merged commit c7c72f5 into main Nov 7, 2023
9 of 13 checks passed
@andrewmooreio andrewmooreio deleted the add-ssm-terminatesession-to-oidc-role branch November 7, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants