Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iam.tf #5193

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update iam.tf #5193

merged 1 commit into from
Oct 10, 2023

Conversation

ep-93
Copy link
Contributor

@ep-93 ep-93 commented Oct 10, 2023

  • Requested in the ask channel.

@ep-93 ep-93 requested a review from a team as a code owner October 10, 2023 08:17
@ep-93 ep-93 temporarily deployed to production October 10, 2023 08:17 — with GitHub Actions Inactive
@ep-93 ep-93 temporarily deployed to production October 10, 2023 08:17 — with GitHub Actions Inactive
@ep-93 ep-93 temporarily deployed to production October 10, 2023 08:17 — with GitHub Actions Inactive
@ep-93 ep-93 temporarily deployed to production October 10, 2023 08:17 — with GitHub Actions Inactive
@dms1981
Copy link
Contributor

dms1981 commented Oct 10, 2023

@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/core-shared-services

*****************************

Running TFSEC in terraform/environments/core-shared-services
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             3.638027ms
  parsing              5.345239547s
  adaptation           14.028181ms
  checks               23.081233ms
  total                5.385986988s

  counts
  ──────────────────────────────────────────
  modules downloaded   5
  modules processed    33
  blocks processed     648
  files read           147

  results
  ──────────────────────────────────────────
  passed               123
  ignored              122
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/core-shared-services

*****************************

Running Checkov in terraform/environments/core-shared-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2023-10-10 08:20:48,216 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2023-10-10 08:20:48,216 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=6819b090bce6d3068d55c7c7b9b3fd18c9dca648:None (for external modules, the --download-external-modules flag is required)
2023-10-10 08:20:48,217 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
2023-10-10 08:20:48,217 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-lambda-function?ref=20e0d9e27402d1e012159a41b474da908d74941b:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 634, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/core-shared-services

*****************************

Running tflint in terraform/environments/core-shared-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ep-93 ep-93 merged commit 36656e4 into main Oct 10, 2023
@ep-93 ep-93 deleted the feature/adding-datasync branch October 10, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants