Skip to content

Commit

Permalink
Removing tf trace logging from the scheduled baseline (#6014)
Browse files Browse the repository at this point in the history
* trivy_exclude unknown

* add checkov skips for fleet manager policy

* Removing tf trace logging from the scheduled baseline

* Reverting trivy exclude input

---------

Co-authored-by: Aaron Robinson <aaron.robinson@digital.justice.gov.uk>
  • Loading branch information
ewastempel and ASTRobinson authored Jan 17, 2024
1 parent a86b03f commit f37922b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/scheduled-baseline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ on:

env:
TF_IN_AUTOMATION: true
TF_LOG: "TRACE"
AWS_REGION: "eu-west-2"
ENVIRONMENT_MANAGEMENT: ${{ secrets.MODERNISATION_PLATFORM_ENVIRONMENTS }}

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/terraform-static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ jobs:
with:
scan_type: changed
trivy_severity: HIGH,CRITICAL
# tfsec_exclude: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
trivy_exclude: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
tfsec_exclude: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
checkov_exclude: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
tflint_exclude: terraform_unused_declarations
tflint_call_module_type: none
Expand Down
2 changes: 2 additions & 0 deletions terraform/environments/bootstrap/delegate-access/policies.tf
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,8 @@ resource "aws_iam_policy" "fleet-manager-policy" {


data "aws_iam_policy_document" "fleet-manager-document" {
#checkov:skip=CKV_AWS_111 Needs to access multiple resources and the policy is attached to a role that is scoped to a specific account
#checkov:skip=CKV_AWS_356 Needs to access multiple resources and the policy is attached to a role that is scoped to a specific account
override_policy_documents = [data.aws_iam_policy_document.common_statements.json]
statement {
sid = "FleetManagerAllow"
Expand Down

0 comments on commit f37922b

Please sign in to comment.