Skip to content

Commit

Permalink
switched behaviour of squash messages and titles to true by default
Browse files Browse the repository at this point in the history
  • Loading branch information
dms1981 committed Dec 6, 2024
1 parent edbf539 commit 17087ee
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions terraform/github/modules/repository/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ variable "secrets" {
variable "squash_merge_commit_message" {
type = bool
description = "Should squash merge commit message be set to MERGE_MESSAGE?"
default = false
default = true
}

variable "squash_merge_commit_title" {
type = bool
description = "Should squash merge commit title be set to PR_TITLE?"
default = false
default = true
}

variable "topics" {
Expand Down
12 changes: 6 additions & 6 deletions terraform/github/repositories.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ module "core" {
"aws",
"documentation"
]
squash_merge_commit_message = true
squash_merge_commit_title = true
secrets = {
# Terraform GitHub token for the CI/CD user
TERRAFORM_GITHUB_TOKEN = data.aws_secretsmanager_secret_version.github_ci_user_token.secret_string
Expand Down Expand Up @@ -52,10 +50,12 @@ module "terraform-module-cross-account-access" {
}

module "terraform-module-environments" {
source = "./modules/repository"
name = "modernisation-platform-terraform-environments"
type = "module"
description = "Module for creating organizational units and accounts within AWS Organizations from JSON files"
source = "./modules/repository"
name = "modernisation-platform-terraform-environments"
type = "module"
description = "Module for creating organizational units and accounts within AWS Organizations from JSON files"
squash_merge_commit_message = false
squash_merge_commit_title = false
topics = [
"organizational-units",
"aws"
Expand Down

0 comments on commit 17087ee

Please sign in to comment.