This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
🔐 Reduce permissions in documentation.yml workflow
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connormaglynn
commented
Oct 17, 2023
| @@ -5,18 +5,20 @@ on: | |||
| branches: | |||
| - main | |||
|
|
|||
| permissions: { } | |||
There was a problem hiding this comment.
The checkgov issue didn't like the default permissions, setting these removes them all
There was a problem hiding this comment.
Does it still use the default permissions?
There was a problem hiding this comment.
Removes all the permissions (REF)
You can use the following syntax to disable permissions for all of the available scopes:
permissions: {}
There was a problem hiding this comment.
This action writes to pull requests so you will need a minimum of:
permissions:
contents: read
pull_request: writeThere was a problem hiding this comment.
@jakemulley turns out it's
permissions:
contents: writeSince you need contents: write to write to a file and pull_request:write is for data on the PR such as labels, assignees, reviewers, comments etc. (REF)
connormaglynn
changed the title
documentation.yml workflow
dms1981
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.