Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise bucket policy to enforce tls v1.2 or higher connections #511

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

pricemg
Copy link
Contributor

@pricemg pricemg commented Aug 15, 2024

Bumping from just enforcing connections over HTTPS to ensuring the connection is using at least TLS v1.2 (and therefore inherently using https). This aligns with comments raised in various IT health checks. (see e.g. here for an example implementing the policy).

Bumping from just enforcing connections over HTTPS to ensuring the connection is using at least TLS v1.2 (and therefore inherently using https). This aligns with comments raised in various IT health checks.
@pricemg pricemg requested a review from a team as a code owner August 15, 2024 11:00
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - aligns nicely with AWS guidance.

@dms1981 dms1981 merged commit 6c10893 into main Aug 15, 2024
4 checks passed
@dms1981 dms1981 deleted the enforce_tls_12_or_higher branch August 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants