Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump ministryofjustice/github-actions from 13 to 14 #197

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2023

Bumps ministryofjustice/github-actions from 13 to 14.

Release notes

Sourced from ministryofjustice/github-actions's releases.

v14

What's Changed

New Contributors

Full Changelog: ministryofjustice/github-actions@v13...v14

Commits
  • 7c689fe Merge pull request #202 from ministryofjustice/bug/tflint
  • e1f7172 Update terraform-static-analysis/entrypoint.sh
  • 95b6694 Update entrypoint.sh
  • b91e9ef Bump ministryofjustice/github-actions from 12 to 13 (#199)
  • 1c06edf Bump int128/hide-comment-action from 1.22.0 to 1.23.0 (#197)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ministryofjustice/github-actions](https://github.com/ministryofjustice/github-actions) from 13 to 14.
- [Release notes](https://github.com/ministryofjustice/github-actions/releases)
- [Commits](ministryofjustice/github-actions@de29cc1...7c689fe)

---
updated-dependencies:
- dependency-name: ministryofjustice/github-actions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner June 26, 2023 10:03
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jun 26, 2023
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             251.002µs
  parsing              20.001229ms
  adaptation           355.704µs
  checks               22.569459ms
  total                43.177394ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     42
  files read           4

  results
  ──────────────────────────────────────────
  passed               8
  ignored              4
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
terraform scan results:

Passed checks: 79, Failed checks: 6, Skipped checks: 16

Check: CKV_AWS_300: "Ensure S3 lifecycle configuration sets period for aborting failed uploads"
	FAILED for resource: module.s3.aws_s3_bucket_lifecycle_configuration.default
	File: /main.tf:39-98
	Calling File: /test/unit-test/main.tf:1-9

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
Check: CKV_AWS_300: "Ensure S3 lifecycle configuration sets period for aborting failed uploads"
	FAILED for resource: module.s3_with_AES256.aws_s3_bucket_lifecycle_configuration.default
	File: /main.tf:39-98
	Calling File: /test/unit-test/main.tf:11-20

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
Check: CKV2_AWS_62: "Ensure S3 buckets should have event notifications enabled"
	FAILED for resource: module.s3.aws_s3_bucket.default
	File: /main.tf:8-19

		8  | resource "aws_s3_bucket" "default" {
		9  |   #checkov:skip=CKV_AWS_144: "Replication handled in replication configuration resource"
		10 |   #checkov:skip=CKV_AWS_18: "Logging handled in logging configuration resource"
		11 |   #checkov:skip=CKV_AWS_21: "Versioning handled in Versioning configuration resource"
		12 |   #checkov:skip=CKV_AWS_145: "Encryption handled in encryption configuration resource"
		13 | 
		14 |   bucket        = var.bucket_name
		15 |   bucket_prefix = var.bucket_prefix
		16 |   force_destroy = var.force_destroy
		17 | 
		18 |   tags = var.tags
		19 | }

Check: CKV2_AWS_62: "Ensure S3 buckets should have event notifications enabled"
	FAILED for resource: module.s3.aws_s3_bucket.replication
	File: /main.tf:230-243

		230 | resource "aws_s3_bucket" "replication" {
		231 |   #checkov:skip=CKV_AWS_144: "Replication not required on replication bucket"
		232 |   #checkov:skip=CKV_AWS_18: "Logging handled in logging configuration resource"
		233 |   #checkov:skip=CKV_AWS_21: "Versioning handled in versioning configuration resource"
		234 |   #checkov:skip=CKV_AWS_145: "Encryption handled in encryption configuration resource"
		235 | 
		236 |   count = var.replication_enabled ? 1 : 0
		237 | 
		238 |   provider      = aws.bucket-replication
		239 |   bucket        = (var.bucket_name != null) ? "${var.bucket_name}-replication" : null
		240 |   bucket_prefix = (var.bucket_prefix != null) ? "${var.bucket_prefix}-replication" : null
		241 |   force_destroy = var.force_destroy
		242 |   tags          = var.tags
		243 | }

Check: CKV2_AWS_62: "Ensure S3 buckets should have event notifications enabled"
	FAILED for resource: module.s3_with_AES256.aws_s3_bucket.default
	File: /main.tf:8-19

		8  | resource "aws_s3_bucket" "default" {
		9  |   #checkov:skip=CKV_AWS_144: "Replication handled in replication configuration resource"
		10 |   #checkov:skip=CKV_AWS_18: "Logging handled in logging configuration resource"
		11 |   #checkov:skip=CKV_AWS_21: "Versioning handled in Versioning configuration resource"
		12 |   #checkov:skip=CKV_AWS_145: "Encryption handled in encryption configuration resource"
		13 | 
		14 |   bucket        = var.bucket_name
		15 |   bucket_prefix = var.bucket_prefix
		16 |   force_destroy = var.force_destroy
		17 | 
		18 |   tags = var.tags
		19 | }

Check: CKV2_AWS_62: "Ensure S3 buckets should have event notifications enabled"
	FAILED for resource: module.s3_with_AES256.aws_s3_bucket.replication
	File: /main.tf:230-243

		230 | resource "aws_s3_bucket" "replication" {
		231 |   #checkov:skip=CKV_AWS_144: "Replication not required on replication bucket"
		232 |   #checkov:skip=CKV_AWS_18: "Logging handled in logging configuration resource"
		233 |   #checkov:skip=CKV_AWS_21: "Versioning handled in versioning configuration resource"
		234 |   #checkov:skip=CKV_AWS_145: "Encryption handled in encryption configuration resource"
		235 | 
		236 |   count = var.replication_enabled ? 1 : 0
		237 | 
		238 |   provider      = aws.bucket-replication
		239 |   bucket        = (var.bucket_name != null) ? "${var.bucket_name}-replication" : null
		240 |   bucket_prefix = (var.bucket_prefix != null) ? "${var.bucket_prefix}-replication" : null
		241 |   force_destroy = var.force_destroy
		242 |   tags          = var.tags
		243 | }

github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@davidkelliott davidkelliott merged commit 5b5c8d5 into main Jun 26, 2023
@davidkelliott davidkelliott deleted the dependabot/github_actions/ministryofjustice/github-actions-14 branch June 26, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant