Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove splat operator from output to get string not string #137

Merged
merged 1 commit into from
May 1, 2024

Conversation

georgepstaylor
Copy link
Contributor

@georgepstaylor georgepstaylor commented May 1, 2024

accessing [*] provides a list - move to [0] so that a string is output instead

@georgepstaylor georgepstaylor requested a review from a team as a code owner May 1, 2024 08:09
Copy link
Contributor

github-actions bot commented May 1, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
service


Running Trivy in service
2024-05-01T08:11:25.881Z �[34mINFO�[0m Need to update DB
2024-05-01T08:11:25.881Z �[34mINFO�[0m DB Repository: ghcr.io/aquasecurity/trivy-db:2
2024-05-01T08:11:25.881Z �[34mINFO�[0m Downloading DB...
2024-05-01T08:11:27.733Z �[34mINFO�[0m Vulnerability scanning is enabled
2024-05-01T08:11:27.733Z �[34mINFO�[0m Misconfiguration scanning is enabled
2024-05-01T08:11:27.733Z �[34mINFO�[0m Need to update the built-in policies
2024-05-01T08:11:27.733Z �[34mINFO�[0m Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-01T08:11:27.952Z �[34mINFO�[0m Secret scanning is enabled
2024-05-01T08:11:27.952Z �[34mINFO�[0m If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-01T08:11:27.952Z �[34mINFO�[0m Please see also https://aquasecurity.github.io/trivy/v0.50/docs/scanner/secret/#recommendation for faster secret detection
2024-05-01T08:11:28.667Z �[34mINFO�[0m Number of language-specific files: 0
2024-05-01T08:11:28.667Z �[34mINFO�[0m Detected config files: 1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
service

*****************************

Running Checkov in service
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 8, Failed checks: 0, Skipped checks: 2


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
service

*****************************

Running tflint in service
Excluding the following checks: terraform_unused_declarations
2 issue(s) found:

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_required_version.md

Warning: Missing version constraint for provider "aws" in `required_providers` (terraform_required_providers)

  on service/task_def.tf line 43:
  43: resource "aws_ecs_task_definition" "ignore_changes" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_required_providers.md

tflint_exitcode=2

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
service

*****************************

Running Trivy in service
2024-05-01T08:11:25.881Z	�[34mINFO�[0m	Need to update DB
2024-05-01T08:11:25.881Z	�[34mINFO�[0m	DB Repository: ghcr.io/aquasecurity/trivy-db:2
2024-05-01T08:11:25.881Z	�[34mINFO�[0m	Downloading DB...
2024-05-01T08:11:27.733Z	�[34mINFO�[0m	Vulnerability scanning is enabled
2024-05-01T08:11:27.733Z	�[34mINFO�[0m	Misconfiguration scanning is enabled
2024-05-01T08:11:27.733Z	�[34mINFO�[0m	Need to update the built-in policies
2024-05-01T08:11:27.733Z	�[34mINFO�[0m	Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-01T08:11:27.952Z	�[34mINFO�[0m	Secret scanning is enabled
2024-05-01T08:11:27.952Z	�[34mINFO�[0m	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-01T08:11:27.952Z	�[34mINFO�[0m	Please see also https://aquasecurity.github.io/trivy/v0.50/docs/scanner/secret/#recommendation for faster secret detection
2024-05-01T08:11:28.667Z	�[34mINFO�[0m	Number of language-specific files: 0
2024-05-01T08:11:28.667Z	�[34mINFO�[0m	Detected config files: 1
trivy_exitcode=0

@georgepstaylor georgepstaylor changed the title Update outputs.tf Remove splat operator from output to get string not string May 1, 2024
@andrewmooreio andrewmooreio merged commit c0e0768 into main May 1, 2024
8 of 9 checks passed
@andrewmooreio andrewmooreio deleted the no-splatting branch May 1, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants