Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 7412 - added AmazonSSMManagedInstanceCore policy #437

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Kudzai-moj
Copy link
Contributor

@Kudzai-moj Kudzai-moj commented Jul 26, 2024

A reference to the issue / Description of it

#7412

How does this PR fix the problem?

PR adds the SSM policy as a default when an instance is created through the module

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

Tested by calling the module with instances that both have the policy already and instances instances that do not have the policy and the change did not break.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@Kudzai-moj Kudzai-moj requested a review from a team as a code owner July 26, 2024 10:18
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kudzai-moj Kudzai-moj merged commit 1740248 into main Jul 26, 2024
2 checks passed
@Kudzai-moj Kudzai-moj deleted the feature/7412-adding-SSM-policy-to-ec2-module branch July 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants