Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new outputs and test outputs and randomising resource names #241

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

ewastempel
Copy link
Contributor

This PR is to do with the ministryofjustice/modernisation-platform#4803 issue.

This issue is already implemented, but this PR is to improve the terratests that are in place.
This change is to introduce new outputs in the module and to use them later on in the terratests. This change is also adding random values to resources names in the terratests to allow smooth standing up and tearing down of the test environments.
This has been tested locally.

@ewastempel ewastempel requested a review from a team as a code owner November 13, 2023 16:27
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             162.574µs
  parsing              7.649663ms
  adaptation           107.602µs
  checks               3.306924ms
  total                11.226763ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     53
  files read           6

  results
  ──────────────────────────────────────────
  passed               2
  ignored              1
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
terraform scan results:

Passed checks: 49, Failed checks: 0, Skipped checks: 14

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@ewastempel ewastempel merged commit 31e0abd into main Nov 13, 2023
@ewastempel ewastempel deleted the feature-backup-tests branch November 13, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants