Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSOS-2838: instance refresh fix #339

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

drobinson-moj
Copy link
Contributor

You can't enable instance refresh if the launch template is set to $Default. Needs to be set to latest version as per AWS docs.
Regresssion tested in nomis-test (didn't break anything)
Instance refresh now working with this change in nomis-preproduction

@drobinson-moj drobinson-moj requested a review from a team as a code owner June 6, 2024 14:06
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; looks like the unit tests still need some improvement though as they failed due to duplicate resources

@dms1981 dms1981 merged commit 7174e58 into main Jun 6, 2024
3 of 4 checks passed
@dms1981 dms1981 deleted the DSOS-2838/enable-auto-instance-refresh branch June 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants