Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSOS-2590: allow healthcheck protocol specify and remove unused variable #252

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

drobinson-moj
Copy link
Contributor

@drobinson-moj drobinson-moj commented Feb 1, 2024

This change is a fix to the LB target groups - allows healthcheck protocol to be specified. This currently defaults to http but sometimes https is required.
Also removed an unused variable.

I've done a sweep of environments repo and this is only used by DSO and delius-iaps,, and delius doesn't use this functionality, so won't be impacting to anybody else.

Tested in DSO applications against this branch

@drobinson-moj drobinson-moj requested a review from a team as a code owner February 1, 2024 10:50
Copy link
Contributor

github-actions bot commented Feb 1, 2024

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             140.742µs
  parsing              18.964979ms
  adaptation           218.317µs
  checks               3.421264ms
  total                22.745302ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     54
  files read           6

  results
  ──────────────────────────────────────────
  passed               3
  ignored              1
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
terraform scan results:

Passed checks: 66, Failed checks: 0, Skipped checks: 13

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

Copy link
Contributor

@Khatraf Khatraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drobinson-moj drobinson-moj merged commit 06257a8 into main Feb 1, 2024
10 checks passed
@drobinson-moj drobinson-moj deleted the DSOS-2590-load-balancer-healthcheck-fix branch February 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants