Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for MP S3 KMS key #566

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Add alias for MP S3 KMS key #566

merged 2 commits into from
Oct 14, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Oct 14, 2024

Tracked upstream by #7569.

This PR adds a name_prefixed KMS alias to identify the KMS key used by the bastion module. A forthcoming PR will add unit tests.

@dms1981 dms1981 requested a review from a team as a code owner October 14, 2024 10:39
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@ASTRobinson ASTRobinson deleted the feature/7569-kms-alias branch October 14, 2024 10:50
@ASTRobinson ASTRobinson restored the feature/7569-kms-alias branch October 14, 2024 10:50
@ASTRobinson ASTRobinson reopened this Oct 14, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@ASTRobinson ASTRobinson merged commit 0a2c49f into main Oct 14, 2024
4 of 5 checks passed
@ASTRobinson ASTRobinson deleted the feature/7569-kms-alias branch October 14, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants