Allow using a custom kms key #351

georgepstaylor · 2024-01-26T12:45:02Z

Adds the ability to pass a custom kms key into the module so that s3 bucket objects can be encrypted with the business uni kms key

github-actions · 2024-01-26T12:47:16Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 198.478µs
parsing 893.396639ms
adaptation 602.531µs
checks 3.836691ms
total 898.034339ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 105
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-01-26 12:47:12,202 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 67, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 62:
  62: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 71:
  71: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-01-26T12:52:39Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 248.643µs
parsing 755.310981ms
adaptation 699.008µs
checks 7.812405ms
total 764.071037ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 105
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-01-26 12:52:35,616 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 67, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 62:
  62: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 71:
  71: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-01T16:27:22Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 229.1µs
parsing 658.890995ms
adaptation 572.648µs
checks 6.724269ms
total 666.417012ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 106
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-01 16:27:17,979 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 74, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-01T16:40:45Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 1.312364ms
parsing 310.931763ms
adaptation 1.387113ms
checks 7.274731ms
total 320.905971ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 106
files read 8

results
──────────────────────────────────────────
passed 15
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-01 16:40:43,544 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:17:00Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 242.42µs
parsing 660.073224ms
adaptation 1.197481ms
checks 3.882319ms
total 665.395444ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 15
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:16:56,185 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:18:50Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 193.223µs
parsing 460.902708ms
adaptation 575.061µs
checks 9.697217ms
total 471.368209ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 15
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:18:47,651 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:20:59Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 212.739µs
parsing 480.111903ms
adaptation 609.967µs
checks 5.312452ms
total 486.247061ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 15
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:20:56,610 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:22:31Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 245.205µs
parsing 314.400354ms
adaptation 1.400917ms
checks 4.091479ms
total 320.137955ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:22:28,943 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 74, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:27:12Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 213.719µs
parsing 339.600173ms
adaptation 611.611µs
checks 3.646704ms
total 344.072207ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:27:10,551 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 74, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:33:21Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 212.917µs
parsing 295.1568ms
adaptation 577.818µs
checks 5.576892ms
total 301.524427ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 15
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:33:18,919 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 74, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-02T12:37:00Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 251.317µs
parsing 311.471369ms
adaptation 561.167µs
checks 8.875716ms
total 321.159569ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 107
files read 9

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-02 12:36:58,472 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 68:
  68: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 77:
  77: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

`Trivy Scan`

Show Output

github-actions · 2024-02-09T11:09:49Z

`TFSEC Scan` Success

Show Output

```hcl

TFSEC will check the following folders:
.

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 258.734µs
parsing 971.697207ms
adaptation 570.954µs
checks 6.274658ms
total 978.801553ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 105
files read 9

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-09 11:09:45,412 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

`Trivy Scan`

Show Output

davidkelliott

Looks good, thanks for this!

georgepstaylor requested a review from a team as a code owner January 26, 2024 12:45

georgepstaylor added 5 commits February 1, 2024 16:24

pass in custom kms key

e33cba7

rename to custom

7280f93

add role output

2d5f82d

indexing for count

0067569

also use for s3 bucket module

b74069e

davidkelliott force-pushed the custom_kms_key branch from 4e03896 to b74069e Compare February 1, 2024 16:25

davidkelliott and others added 3 commits February 1, 2024 16:38

Fix kms_key var required and len not valid function

6478381

terraform-docs: automated action

c089af6

Commit changes made by code formatters

a1bb699

George Taylor added 2 commits February 2, 2024 12:14

kms-key

b6af4a3

list

d07c428

George Taylor and others added 3 commits February 2, 2024 12:18

local logic

03ca2ae

default null

b2e082a

terraform-docs: automated action

3ed3bef

empty string required for s3 moduel

d02c574

refactor

afc99e6

George Taylor and others added 2 commits February 2, 2024 12:34

change defautl

4b5b7a0

terraform-docs: automated action

f34f3ea

davidkelliott closed this Feb 9, 2024

davidkelliott reopened this Feb 9, 2024

davidkelliott approved these changes Feb 9, 2024

View reviewed changes

davidkelliott merged commit 908abb9 into main Feb 9, 2024
5 checks passed

davidkelliott deleted the custom_kms_key branch February 9, 2024 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow using a custom kms key #351

Allow using a custom kms key #351

georgepstaylor commented Jan 26, 2024

github-actions bot commented Jan 26, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Jan 26, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 1, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 1, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 2, 2024

You can read more here:
aquasecurity/tfsec#1994

github-actions bot commented Feb 9, 2024

You can read more here:
aquasecurity/tfsec#1994

davidkelliott left a comment

Allow using a custom kms key #351

Allow using a custom kms key #351

Conversation

georgepstaylor commented Jan 26, 2024

github-actions bot commented Jan 26, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Jan 26, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 1, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 1, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 2, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Failed

Trivy Scan

github-actions bot commented Feb 9, 2024

TFSEC Scan Success

You can read more here: aquasecurity/tfsec#1994

CTFLint Scan Success

Trivy Scan

davidkelliott left a comment

Choose a reason for hiding this comment

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Failed

`Trivy Scan`

`TFSEC Scan` Success

You can read more here:
aquasecurity/tfsec#1994

`CTFLint Scan` Success

`Trivy Scan`