Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5899 #339

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Issue 5899 #339

merged 1 commit into from
Jan 22, 2024

Conversation

mikereiddigital
Copy link
Contributor

Adds fix for issue 5899 and increments release of github-actions to 15.3.0.

@mikereiddigital mikereiddigital requested a review from a team as a code owner January 15, 2024 14:37
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
.


Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 224.217µs
parsing 658.275245ms
adaptation 583.877µs
checks 5.972109ms
total 665.055448ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 103
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-01-15 14:39:20,362 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 70, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 62:
  62: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 71:
  71: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

Trivy Scan

Show Output

Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
.


Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 186.919µs
parsing 740.670976ms
adaptation 548.255µs
checks 9.318122ms
total 750.724272ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 103
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-01-22 09:35:18,608 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 70, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
2 issue(s) found:

Warning: [Fixable] variable "bucket_versioning" is declared but not used (terraform_unused_declarations)

  on variables.tf line 62:
  62: variable "bucket_versioning" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

Warning: [Fixable] variable "bucket_force_destroy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 71:
  71: variable "bucket_force_destroy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

Trivy Scan

Show Output

@ASTRobinson ASTRobinson merged commit 2a6a66e into main Jan 22, 2024
6 of 10 checks passed
@ASTRobinson ASTRobinson deleted the issue-5899 branch January 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants