Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rename KMS key for sechub" #637

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

richgreen-moj
Copy link
Contributor

@richgreen-moj richgreen-moj commented Oct 23, 2024

Reverts #635
I'm going to try using name_prefix instead as it will add a unique ID to the name.

@richgreen-moj richgreen-moj requested a review from a team as a code owner October 23, 2024 17:04
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
modules/securityhub
test/securityhub-test


Running Trivy in modules/securityhub
2024-10-23T17:06:14Z INFO [vulndb] Need to update DB
2024-10-23T17:06:14Z INFO [vulndb] Downloading vulnerability DB...
2024-10-23T17:06:14Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-23T17:06:16Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-23T17:06:16Z INFO [vuln] Vulnerability scanning is enabled
2024-10-23T17:06:16Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-23T17:06:16Z INFO [misconfig] Need to update the built-in checks
2024-10-23T17:06:16Z INFO [misconfig] Downloading the built-in checks...
2024-10-23T17:06:16Z ERROR [misconfig] Falling back to embedded checks err="failed to download built-in policies: download error: OCI repository error: 1 error occurred:\n\t* GET https://ghcr.io/v2/aquasecurity/trivy-checks/manifests/1: TOOMANYREQUESTS: retry-after: 71.346µs, allowed: 44000/minute\n\n"
2024-10-23T17:06:16Z INFO [secret] Secret scanning is enabled
2024-10-23T17:06:16Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-23T17:06:16Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-23T17:06:17Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-23T17:06:17Z INFO Number of language-specific files num=0
2024-10-23T17:06:17Z INFO Detected config files num=1
trivy_exitcode=0


Running Trivy in test/securityhub-test
2024-10-23T17:06:17Z INFO [vuln] Vulnerability scanning is enabled
2024-10-23T17:06:17Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-23T17:06:17Z INFO [misconfig] Need to update the built-in checks
2024-10-23T17:06:17Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-23T17:06:17Z INFO [secret] Secret scanning is enabled
2024-10-23T17:06:17Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-23T17:06:17Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-23T17:06:18Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-23T17:06:18Z INFO Number of language-specific files num=0
2024-10-23T17:06:18Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/securityhub
test/securityhub-test

*****************************

Running Checkov in modules/securityhub
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-10-23 17:06:21,299 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 0, Skipped checks: 3


checkov_exitcode=0

*****************************

Running Checkov in test/securityhub-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 28, Failed checks: 0, Skipped checks: 3


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
modules/securityhub
test/securityhub-test

*****************************

Running tflint in modules/securityhub
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in test/securityhub-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
modules/securityhub
test/securityhub-test

*****************************

Running Trivy in modules/securityhub
2024-10-23T17:06:14Z	INFO	[vulndb] Need to update DB
2024-10-23T17:06:14Z	INFO	[vulndb] Downloading vulnerability DB...
2024-10-23T17:06:14Z	INFO	[vulndb] Downloading artifact...	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-23T17:06:16Z	INFO	[vulndb] Artifact successfully downloaded	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-23T17:06:16Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-23T17:06:16Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-23T17:06:16Z	INFO	[misconfig] Need to update the built-in checks
2024-10-23T17:06:16Z	INFO	[misconfig] Downloading the built-in checks...
2024-10-23T17:06:16Z	ERROR	[misconfig] Falling back to embedded checks	err="failed to download built-in policies: download error: OCI repository error: 1 error occurred:\n\t* GET https://ghcr.io/v2/aquasecurity/trivy-checks/manifests/1: TOOMANYREQUESTS: retry-after: 71.346µs, allowed: 44000/minute\n\n"
2024-10-23T17:06:16Z	INFO	[secret] Secret scanning is enabled
2024-10-23T17:06:16Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-23T17:06:16Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-23T17:06:17Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-23T17:06:17Z	INFO	Number of language-specific files	num=0
2024-10-23T17:06:17Z	INFO	Detected config files	num=1
trivy_exitcode=0

*****************************

Running Trivy in test/securityhub-test
2024-10-23T17:06:17Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-23T17:06:17Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-23T17:06:17Z	INFO	[misconfig] Need to update the built-in checks
2024-10-23T17:06:17Z	INFO	[misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-23T17:06:17Z	INFO	[secret] Secret scanning is enabled
2024-10-23T17:06:17Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-23T17:06:17Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-23T17:06:18Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-23T17:06:18Z	INFO	Number of language-specific files	num=0
2024-10-23T17:06:18Z	INFO	Detected config files	num=1
trivy_exitcode=0

@richgreen-moj richgreen-moj merged commit a8fd326 into main Oct 23, 2024
6 checks passed
@richgreen-moj richgreen-moj deleted the revert-635-feature/8076-change-kms-alias branch October 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants