Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GetMacieSession from SecurityHub Alarm #599

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

davidkelliott
Copy link
Contributor

When Macie is not enabled on an account, this gives a false positive for unauthorized api calls in the security hub metric.

By excluding this we should see less false alarms.

https://repost.aws/it/questions/QU8ZC1xd9BQV2vnGkod7gQww/macie-not-enabled-means-false-positive-accessdeniedexceptions-in-cloudtrail

Tested filter in cloudwatch core-shared-services
Old - 2 results including a getmaciesession

New - 1 result, no getmaciesession

When Macie is not enabled on an account, this gives a false positive for unauthorized api calls in the security hub metric.

By excluding this we should see less false alarms.

https://repost.aws/it/questions/QU8ZC1xd9BQV2vnGkod7gQww/macie-not-enabled-means-false-positive-accessdeniedexceptions-in-cloudtrail
@davidkelliott davidkelliott requested a review from a team as a code owner October 1, 2024 08:51
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
modules/securityhub-alarms


Running Trivy in modules/securityhub-alarms
2024-10-01T08:53:17Z INFO [db] Need to update DB
2024-10-01T08:53:17Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-10-01T08:53:18Z INFO [vuln] Vulnerability scanning is enabled
2024-10-01T08:53:18Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-01T08:53:18Z INFO Need to update the built-in policies
2024-10-01T08:53:18Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-10-01T08:53:19Z INFO [secret] Secret scanning is enabled
2024-10-01T08:53:19Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-01T08:53:19Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-10-01T08:53:19Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-01T08:53:19Z INFO Number of language-specific files num=0
2024-10-01T08:53:19Z INFO Detected config files num=2
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
modules/securityhub-alarms

*****************************

Running Checkov in modules/securityhub-alarms
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 36, Failed checks: 0, Skipped checks: 3


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
modules/securityhub-alarms

*****************************

Running tflint in modules/securityhub-alarms
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
modules/securityhub-alarms

*****************************

Running Trivy in modules/securityhub-alarms
2024-10-01T08:53:17Z	INFO	[db] Need to update DB
2024-10-01T08:53:17Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-10-01T08:53:18Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-01T08:53:18Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-01T08:53:18Z	INFO	Need to update the built-in policies
2024-10-01T08:53:18Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-10-01T08:53:19Z	INFO	[secret] Secret scanning is enabled
2024-10-01T08:53:19Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-01T08:53:19Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-10-01T08:53:19Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-01T08:53:19Z	INFO	Number of language-specific files	num=0
2024-10-01T08:53:19Z	INFO	Detected config files	num=2
trivy_exitcode=0

@davidkelliott davidkelliott merged commit 9d62fce into main Oct 1, 2024
4 checks passed
@davidkelliott davidkelliott deleted the feature/exclude-getmaciesession branch October 1, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants