-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin role usage alarm and tests #580
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one
A reference to the issue / Description of it
ministryofjustice/modernisation-platform#7437
How does this PR fix the problem?
This adds a new alarm (and unit tests) which will trigger when anyone assumes the AdministratorAccess role in any MP accounts (Core/Member) in the MP low priority alerts channel.
How has this been tested?
I started by reviewing cloudtrail logs when accessing the role and finding the best way to pinpoint when the role is being assumed.
Then I created a new alarm and metric filter in the baselines module and manually applied it to the
core-shared-services
account (just because I needed an account that was already subscribed to the low priority slack alerts channel). I then assumed the admin role and observed that the alarm triggered and sent us a message.See an example of the alert being raised:
https://moj-digital-tools.pagerduty.com/incidents/Q2NOMBHFB4MYRJ?utm_campaign=channel&utm_source=slack
https://mojdt.slack.com/archives/C02PFCG8M1R/p1724922501200269