Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trivy Findings AVD-AWS-0136 #452

Closed
wants to merge 4 commits into from
Closed

Fix Trivy Findings AVD-AWS-0136 #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cd253c
caps
richgreen-moj May 7, 2024
bfe2991
add trivy ignore to config module sns kms
richgreen-moj May 8, 2024
65595d6
add global ignore AVD-AWS-0136
richgreen-moj May 8, 2024
0d33d83
Commit changes made by code formatters
github-actions[bot] May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .trivyignore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ misconfigurations:
- id: AVD-AWS-0031
- id: AVD-AWS-0039
- id: AVD-AWS-0057
- id: AVD-AWS-0136

secrets:

Expand Down
2 changes: 1 addition & 1 deletion modules/backup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ resource "aws_backup_selection" "non_production" {
}

# SNS topic
#trivy:ignore:avd-aws-0136
#trivy:ignore:AVD-AWS-0136
resource "aws_sns_topic" "backup_failure_topic" {
kms_master_key_id = var.sns_backup_topic_key
name = "backup_failure_topic"
Expand Down
1 change: 1 addition & 0 deletions modules/config/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ resource "aws_config_configuration_recorder_status" "default" {
# Create an SNS topic
# AWS-managed account key appropriate for default topic
# tfsec:ignore:aws-sns-topic-encryption-use-cmk
#trivy:ignore:AVD-AWS-0136
resource "aws_sns_topic" "default" {
name = "config"
kms_master_key_id = "alias/aws/sns"
Expand Down