Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/5012. #376

Merged
merged 1 commit into from
Jan 26, 2024
Merged

issue/5012. #376

merged 1 commit into from
Jan 26, 2024

Conversation

mikereiddigital
Copy link
Contributor

Adds a "aws_ec2_image_block_public_access" resource to the module to prevent any new AMIs created in member accounts from being publicly shared.

Ref: ministryofjustice/modernisation-platform#5012 for further information.

…prevent any new AMIs created in member accounts from being publicly shared.
@mikereiddigital mikereiddigital requested a review from a team as a code owner January 26, 2024 11:34
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
.


Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 631.387µs
parsing 460.747472ms
adaptation 736.609µs
checks 3.794294ms
total 465.909762ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 6
blocks processed 254
files read 32

results
──────────────────────────────────────────
passed 26
ignored 18
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-26 11:36:57,180 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 284, Failed checks: 0, Skipped checks: 85

github_actions scan results:

Passed checks: 132, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

Trivy Scan

Show Output

Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikereiddigital mikereiddigital merged commit 8011886 into main Jan 26, 2024
3 checks passed
@mikereiddigital mikereiddigital deleted the issue/5012 branch January 26, 2024 11:45
Copy link
Contributor

@markgov markgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants