Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump s3-bucket::modernisation-platform-terraform-s3-bucket from 6.2.0 to 6.3.0 #56

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Bump s3-bucket::modernisation-platform-terraform-s3-bucket from 6.2.0 to 6.3.0 #56

merged 1 commit into from
Mar 8, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2023

Bumps s3-bucket::modernisation-platform-terraform-s3-bucket from 6.2.0 to 6.3.0.

Release notes

Sourced from s3-bucket::modernisation-platform-terraform-s3-bucket's releases.

v6.3.0

What's Changed

New Contributors

Full Changelog: ministryofjustice/modernisation-platform-terraform-s3-bucket@v6.2.0...v6.3.0

Commits
  • 981bf39 Merge pull request #81 from ministryofjustice/feature/one-pass-custom-bucket-...
  • 768f5d7 fix test
  • 883ac6c terraform-docs: automated action
  • eb66d89 Merge pull request #80 from ministryofjustice/dependabot/github_actions/bridg...
  • f0c2ba1 allow custom policies to be defined inline allowing for bucket and custom pol...
  • 2de647c Bump bridgecrewio/checkov-action from 12.2161.0 to 12.2164.0
  • 034716a Merge pull request #78 from ministryofjustice/dependabot/github_actions/bridg...
  • 91c7f5b Merge pull request #79 from ministryofjustice/dependabot/github_actions/githu...
  • 87745de Bump github/codeql-action from 2.2.4 to 2.2.5
  • ead31c0 Bump bridgecrewio/checkov-action from 12.2155.0 to 12.2161.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump s3-bucket::modernisation-platform-terraform-s3-bucket
f0917e6 
Bumps [s3-bucket::modernisation-platform-terraform-s3-bucket](https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket/releases)
- [Commits](ministryofjustice/modernisation-platform-terraform-s3-bucket@v6.2.0...v6.3.0)

---
updated-dependencies:
- dependency-name: s3-bucket::github::ministryofjustice/modernisation-platform-terraform-s3-bucket::v6.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner March 1, 2023 12:06
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             176.103µs
  parsing              555.93682ms
  adaptation           635.111µs
  checks               16.095864ms
  total                572.843898ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     53
  files read           9

  results
  ──────────────────────────────────────────
  passed               8
  ignored              28
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output 
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-03-01 12:08:58,065 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.3.0:None (for external modules, the --download-external-modules flag is required)
2023-03-01 12:08:58,066 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-vm-import?ref=v1.0.2:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 2, Skipped checks: 0

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: aws_iam_policy.vmimport-policy
	File: /main.tf:83-116

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: aws_iam_policy.vmimport-policy
	File: /main.tf:83-116

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

github_actions scan results:

Passed checks: 174, Failed checks: 2, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1
Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on
	File: /.github/workflows/go-terratest.yml:0-1

checkov_exitcode=1

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@dms1981 dms1981 merged commit f696f8a into main Mar 8, 2023
@dms1981 dms1981 deleted the dependabot/terraform/s3-bucket--github--ministryofjustice/modernisation-platform-terraform-s3-bucket--v6.2.0-6.3.0 branch March 8, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dms1981 dms1981 dms1981 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dms1981