Bump ministryofjustice/github-actions from 12 to 13 #128

dependabot · 2023-05-18T12:02:00Z

Bumps ministryofjustice/github-actions from 12 to 13.

Release notes

Sourced from ministryofjustice/github-actions's releases.

v13

What's Changed

Bump ministryofjustice/github-actions from 11 to 12 by @dependabot in ministryofjustice/github-actions#196

Terraform static analysis - Change to hardcoded path by @danlumb01 in ministryofjustice/github-actions#198

Full Changelog: ministryofjustice/github-actions@v12...v13

Commits

de29cc1 changing hardcoded directory paths for terraform static analysis (#198)
89c24d3 Bump ministryofjustice/github-actions from 11 to 12 (#196)
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

github-actions · 2023-05-18T12:05:05Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             271.724µs
  parsing              620.007575ms
  adaptation           1.507318ms
  checks               25.451703ms
  total                647.23832ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     53
  files read           9

  results
  ──────────────────────────────────────────
  passed               8
  ignored              28
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-05-18 12:05:01,655 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.3.0:None (for external modules, the --download-external-modules flag is required)
2023-05-18 12:05:01,655 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-vm-import?ref=v1.0.2:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 2, Skipped checks: 0

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: aws_iam_policy.vmimport-policy
	File: /main.tf:83-116

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: aws_iam_policy.vmimport-policy
	File: /main.tf:83-116

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.
tflint_exitcode=0

dependabot · 2023-05-18T14:21:37Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Bumps [ministryofjustice/github-actions](https://github.com/ministryofjustice/github-actions) from 12 to 13. - [Release notes](https://github.com/ministryofjustice/github-actions/releases) - [Commits](ministryofjustice/github-actions@0ec5492...de29cc1) --- updated-dependencies: - dependency-name: ministryofjustice/github-actions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

github-actions · 2023-05-18T14:24:28Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             201.4µs
  parsing              1.187348166s
  adaptation           911.399µs
  checks               16.543294ms
  total                1.205004259s

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     55
  files read           9

  results
  ──────────────────────────────────────────
  passed               8
  ignored              28
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-05-18 14:24:25,414 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.4.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 2, Skipped checks: 0

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.
tflint_exitcode=0

github-actions · 2023-05-18T14:24:30Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             205.002µs
  parsing              404.506123ms
  adaptation           707.612µs
  checks               10.936084ms
  total                416.354821ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     55
  files read           9

  results
  ──────────────────────────────────────────
  passed               8
  ignored              28
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-05-18 14:24:27,588 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.4.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 2, Skipped checks: 0

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.
tflint_exitcode=0

markgov

LGTM

github-actions · 2023-05-18T15:12:55Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             386.403µs
  parsing              699.551026ms
  adaptation           1.081407ms
  checks               24.180357ms
  total                725.199193ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     55
  files read           9

  results
  ──────────────────────────────────────────
  passed               8
  ignored              28
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-05-18 15:12:51,398 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.4.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 2, Skipped checks: 0

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: module.vm-import.aws_iam_policy.vmimport-policy
	File: /main.tf:83-116
	Calling File: /test/unit-test/main.tf:1-10

		83  | resource "aws_iam_policy" "vmimport-policy" {
		84  |   name   = "vmimport-policy-${var.application_name}"
		85  |   policy = <<EOF
		86  | {
		87  |   "Version":"2012-10-17",
		88  |    "Statement":[
		89  |       {
		90  |          "Effect": "Allow",
		91  |          "Action": [
		92  |             "s3:GetBucketLocation",
		93  |             "s3:GetObject",
		94  |             "s3:ListBucket",
		95  |             "s3:PutObject",
		96  |             "s3:GetBucketAcl"
		97  |          ],
		98  |          "Resource": [
		99  |             "${module.s3-bucket.bucket.arn}",
		100 |             "${module.s3-bucket.bucket.arn}/*"
		101 |          ]
		102 |       },
		103 |       {
		104 |          "Effect": "Allow",
		105 |          "Action": [
		106 |             "ec2:ModifySnapshotAttribute",
		107 |             "ec2:CopySnapshot",
		108 |             "ec2:RegisterImage",
		109 |             "ec2:Describe*"
		110 |          ],
		111 |          "Resource": "*"
		112 |       }
		113 |    ]
		114 | }
		115 | EOF
		116 | }

github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.
tflint_exitcode=0

dependabot bot requested a review from a team as a code owner May 18, 2023 12:02

dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 18, 2023

markgov closed this May 18, 2023

markgov reopened this May 18, 2023

dependabot bot force-pushed the dependabot/github_actions/ministryofjustice/github-actions-13 branch from 5e1b60d to fb2f7c1 Compare May 18, 2023 14:22

markgov closed this May 18, 2023

markgov reopened this May 18, 2023

markgov approved these changes May 18, 2023

View reviewed changes

markgov merged commit c0b4e4b into main May 18, 2023

markgov deleted the dependabot/github_actions/ministryofjustice/github-actions-13 branch May 18, 2023 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump ministryofjustice/github-actions from 12 to 13 #128

Bump ministryofjustice/github-actions from 12 to 13 #128

dependabot bot commented on behalf of github May 18, 2023 •

edited

Loading

github-actions bot commented May 18, 2023

dependabot bot commented on behalf of github May 18, 2023

github-actions bot commented May 18, 2023

github-actions bot commented May 18, 2023

markgov left a comment

github-actions bot commented May 18, 2023

Bump ministryofjustice/github-actions from 12 to 13 #128

Bump ministryofjustice/github-actions from 12 to 13 #128

Conversation

dependabot bot commented on behalf of github May 18, 2023 • edited Loading

v13

What's Changed

github-actions bot commented May 18, 2023

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

dependabot bot commented on behalf of github May 18, 2023

github-actions bot commented May 18, 2023

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented May 18, 2023

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

markgov left a comment

Choose a reason for hiding this comment

github-actions bot commented May 18, 2023

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

dependabot bot commented on behalf of github May 18, 2023 •

edited

Loading

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success