Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove awscc resources/providers and replace with new non cc versions #40

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

richgreen-moj
Copy link
Collaborator

Terraform has released proper resources/support for creating chatbot channel configs without the need to use the cloud control (cc) versions (which use cloudformation in the background).

This PR updates to use the newer resources and remove refs to the awscc provider.

@richgreen-moj richgreen-moj requested a review from a team as a code owner September 6, 2024 10:51
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
test/unit-test


Running Trivy in test/unit-test
2024-09-06T10:53:47Z INFO [db] Need to update DB
2024-09-06T10:53:47Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-06T10:53:49Z INFO [vuln] Vulnerability scanning is enabled
2024-09-06T10:53:49Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-06T10:53:49Z INFO Need to update the built-in policies
2024-09-06T10:53:49Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-06T10:53:49Z INFO [secret] Secret scanning is enabled
2024-09-06T10:53:49Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-06T10:53:49Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-06T10:53:49Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-06T10:53:49Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-09-06T10:53:49Z INFO Number of language-specific files num=0
2024-09-06T10:53:49Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
test/unit-test

*****************************

Running Checkov in test/unit-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 8, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
test/unit-test

*****************************

Running tflint in test/unit-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
test/unit-test

*****************************

Running Trivy in test/unit-test
2024-09-06T10:53:47Z	INFO	[db] Need to update DB
2024-09-06T10:53:47Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-06T10:53:49Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-06T10:53:49Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-06T10:53:49Z	INFO	Need to update the built-in policies
2024-09-06T10:53:49Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-06T10:53:49Z	INFO	[secret] Secret scanning is enabled
2024-09-06T10:53:49Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-06T10:53:49Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-06T10:53:49Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-06T10:53:49Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-09-06T10:53:49Z	INFO	Number of language-specific files	num=0
2024-09-06T10:53:49Z	INFO	Detected config files	num=1
trivy_exitcode=0

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
test/unit-test


Running Trivy in test/unit-test
2024-09-06T11:05:52Z INFO [db] Need to update DB
2024-09-06T11:05:52Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-06T11:05:54Z INFO [vuln] Vulnerability scanning is enabled
2024-09-06T11:05:54Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-06T11:05:54Z INFO Need to update the built-in policies
2024-09-06T11:05:54Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-06T11:05:54Z INFO [secret] Secret scanning is enabled
2024-09-06T11:05:54Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-06T11:05:54Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-06T11:05:54Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-06T11:05:54Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-09-06T11:05:54Z INFO Number of language-specific files num=0
2024-09-06T11:05:54Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
test/unit-test

*****************************

Running Checkov in test/unit-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 8, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
test/unit-test

*****************************

Running tflint in test/unit-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
test/unit-test

*****************************

Running Trivy in test/unit-test
2024-09-06T11:05:52Z	INFO	[db] Need to update DB
2024-09-06T11:05:52Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-06T11:05:54Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-06T11:05:54Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-06T11:05:54Z	INFO	Need to update the built-in policies
2024-09-06T11:05:54Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-06T11:05:54Z	INFO	[secret] Secret scanning is enabled
2024-09-06T11:05:54Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-06T11:05:54Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-06T11:05:54Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-06T11:05:54Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-09-06T11:05:54Z	INFO	Number of language-specific files	num=0
2024-09-06T11:05:54Z	INFO	Detected config files	num=1
trivy_exitcode=0

@richgreen-moj richgreen-moj merged commit 73280f8 into main Sep 6, 2024
5 checks passed
@richgreen-moj richgreen-moj deleted the feature/update-resources-from-cc-to-regular branch September 6, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants