Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCAS: update the rds cert to rds-ca-rsa2048-g1 #7026

Merged
merged 1 commit into from
Jul 9, 2024
Merged

NCAS: update the rds cert to rds-ca-rsa2048-g1 #7026

merged 1 commit into from
Jul 9, 2024

Conversation

matt-k1998
Copy link
Contributor

No description provided.

@matt-k1998 matt-k1998 requested review from a team as code owners July 9, 2024 15:08
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Trivy Scan Failed

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/ncas

Running Trivy in terraform/environments/ncas
2024-07-09T15:10:54Z INFO Need to update DB
2024-07-09T15:10:54Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-09T15:10:55Z INFO Vulnerability scanning is enabled
2024-07-09T15:10:55Z INFO Misconfiguration scanning is enabled
2024-07-09T15:10:55Z INFO Need to update the built-in policies
2024-07-09T15:10:55Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-09T15:10:56Z INFO Secret scanning is enabled
2024-07-09T15:10:56Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-09T15:10:56Z INFO Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-09T15:10:57Z INFO Number of language-specific files num=0
2024-07-09T15:10:57Z INFO Detected config files num=7

ecs.tf (terraform)

Tests: 14 (SUCCESSES: 3, FAILURES: 4, EXCEPTIONS: 7)
Failures: 4 (HIGH: 3, CRITICAL: 1)

HIGH: Image scanning is not enabled.
════════════════════════════════════════
Repository image scans should be enabled to ensure vulnerable software can be discovered and remediated as soon as possible.

See https://avd.aquasec.com/misconfig/avd-aws-0030
────────────────────────────────────────
ecs.tf:353-356
────────────────────────────────────────
353 ┌ resource "aws_ecr_repository" "ncas_ecr_repo" {
354 │ name = "ncas-ecr-repo"
355 │ force_delete = true
356 └ }
────────────────────────────────────────

HIGH: Topic does not have encryption enabled.
════════════════════════════════════════
Topics should be encrypted to protect their contents.

See https://avd.aquasec.com/misconfig/avd-aws-0095
────────────────────────────────────────
ecs.tf:452-455
────────────────────────────────────────
452 ┌ resource "aws_sns_topic" "ddos_alarm" {
453 │ count = local.is-development ? 0 : 1
454 │ name = "ncas_ddos_alarm"
455 └ }
────────────────────────────────────────

HIGH: Topic does not have encryption enabled.
════════════════════════════════════════
Topics should be encrypted to protect their contents.

See https://avd.aquasec.com/misconfig/avd-aws-0095
────────────────────────────────────────
ecs.tf:457-460
────────────────────────────────────────
457 ┌ resource "aws_sns_topic" "ncas_utilisation_alarm" {
458 │ count = local.is-development ? 0 : 1
459 │ name = "ncas_utilisation_alarm"
460 └ }
────────────────────────────────────────

CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
ecs.tf:349
via ecs.tf:345-350 (egress)
via ecs.tf:333-351 (aws_security_group.ecs_service)
────────────────────────────────────────
333 resource "aws_security_group" "ecs_service" {
...
349 [ cidr_blocks = ["0.0.0.0/0"]
...
351 }
────────────────────────────────────────

github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.2.1/main.tf (terraform)

Tests: 16 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 11)
Failures: 0 (HIGH: 0, CRITICAL: 0)

load_balancer.tf (terraform)

Tests: 12 (SUCCESSES: 6, FAILURES: 6, EXCEPTIONS: 0)
Failures: 6 (HIGH: 2, CRITICAL: 4)

HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise.

By setting drop_invalid_header_fields to true, anything that doe not conform to well known, defined headers will be removed by the load balancer.

See https://avd.aquasec.com/misconfig/avd-aws-0052
────────────────────────────────────────
load_balancer.tf:235-243
────────────────────────────────────────
235 ┌ resource "aws_lb" "ncas_lb" {
236 │ name = "ncas-load-balancer"
237 │ load_balancer_type = "application"
238 │ security_groups = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
239 │ subnets = data.aws_subnets.shared-public.ids
240 │ enable_deletion_protection = false
241 │ internal = false
242 │ depends_on = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
243 └ }
────────────────────────────────────────

HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.

See https://avd.aquasec.com/misconfig/avd-aws-0053
────────────────────────────────────────
load_balancer.tf:241
via load_balancer.tf:235-243 (aws_lb.ncas_lb)
────────────────────────────────────────
235 resource "aws_lb" "ncas_lb" {
236 name = "ncas-load-balancer"
237 load_balancer_type = "application"
238 security_groups = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
239 subnets = data.aws_subnets.shared-public.ids
240 enable_deletion_protection = false
241 [ internal = false
242 depends_on = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
243 }
────────────────────────────────────────

CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
load_balancer.tf:85
via load_balancer.tf:80-86 (egress)
via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
1 resource "aws_security_group" "ncas_lb_sc" {
.
85 [ cidr_blocks = ["0.0.0.0/0"]
..
87 }
────────────────────────────────────────

CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
load_balancer.tf:77
via load_balancer.tf:72-78 (egress)
via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
1 resource "aws_security_group" "ncas_lb_sc" {
.
77 [ cidr_blocks = ["0.0.0.0/0"]
..
87 }
────────────────────────────────────────

CRITICAL: Security group rule allows ingress from public internet.
════════════════════════════════════════
Opening up ports to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that explicitly require it where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0107
────────────────────────────────────────
load_balancer.tf:55-69
via load_balancer.tf:51-70 (ingress)
via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
1 resource "aws_security_group" "ncas_lb_sc" {
.
55 ┌ cidr_blocks = [
56 │ "20.26.11.71/32",
57 │ "20.26.11.108/32",
58 │ "20.49.214.199/32",
59 │ "20.49.214.228/32",
60 │ "51.149.249.0/29",
61 └ "51.149.249.32/29",
..
────────────────────────────────────────

CRITICAL: Security group rule allows ingress from public internet.
════════════════════════════════════════
Opening up ports to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that explicitly require it where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0107
────────────────────────────────────────
load_balancer.tf:27-47
via load_balancer.tf:23-48 (ingress)
via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
1 resource "aws_security_group" "ncas_lb_sc" {
.
27 ┌ cidr_blocks = [
28 │ "194.33.196.0/25",
29 │ "201.33.21.5/32",
30 │ "93.56.171.15/32",
31 │ "194.33.193.0/25",
32 │ "179.50.12.212/32",
33 └ "54.94.206.111/32",
..
────────────────────────────────────────

rds.tf (terraform)

Tests: 5 (SUCCESSES: 3, FAILURES: 2, EXCEPTIONS: 0)
Failures: 2 (HIGH: 1, CRITICAL: 1)

HIGH: Instance does not have storage encryption enabled.
════════════════════════════════════════
Encryption should be enabled for an RDS Database instances.

When enabling encryption by setting the kms_key_id.

See https://avd.aquasec.com/misconfig/avd-aws-0080
────────────────────────────────────────
rds.tf:1-19
────────────────────────────────────────
1 ┌ resource "aws_db_instance" "ncas_db" {
2 │ count = local.is-development ? 0 : 1
3 │ allocated_storage = local.application_data.accounts[local.environment].allocated_storage
4 │ db_name = local.application_data.accounts[local.environment].db_name
5 │ storage_type = local.application_data.accounts[local.environment].storage_type
6 │ engine = local.application_data.accounts[local.environment].engine
7 │ identifier = local.application_data.accounts[local.environment].identifier
8 │ engine_version = local.application_data.accounts[local.environment].engine_version
9 └ instance_class = local.application_data.accounts[local.environment].instance_class
..
────────────────────────────────────────

CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
rds.tf:60
via rds.tf:55-61 (egress)
via rds.tf:26-62 (aws_security_group.postgresql_db_sc[0])
────────────────────────────────────────
26 resource "aws_security_group" "postgresql_db_sc" {
..
60 [ cidr_blocks = ["0.0.0.0/0"]
..
62 }
────────────────────────────────────────

trivy_exitcode=1

</details> #### `Checkov Scan` Failed
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/ncas

*****************************

Running Checkov in terraform/environments/ncas
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-07-09 15:10:59,863 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=v2.0.0:None (for external modules, the --download-external-modules flag is required)
2024-07-09 15:10:59,863 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.2.1:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 92, Failed checks: 53, Skipped checks: 0

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: bastion_linux
	File: /ec2_bastion_linux.tf:2-31
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		2  | module "bastion_linux" {
		3  |   source = "github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.2.1"
		4  | 
		5  |   providers = {
		6  |     aws.share-host   = aws.core-vpc # core-vpc-(environment) holds the networking for all accounts
		7  |     aws.share-tenant = aws          # The default provider (unaliased, `aws`) is the tenant
		8  |   }
		9  |   # s3 - used for logs and user ssh public keys
		10 |   bucket_name = "bastion-example"
		11 |   # bucket_versioning    = true
		12 |   # bucket_force_destroy = true
		13 |   # public keys
		14 |   public_key_data = local.public_key_data.keys[local.environment]
		15 |   # logs
		16 |   log_auto_clean       = "Enabled"
		17 |   log_standard_ia_days = 30  # days before moving to IA storage
		18 |   log_glacier_days     = 60  # days before moving to Glacier
		19 |   log_expiry_days      = 180 # days before log expiration
		20 |   # bastion
		21 |   allow_ssh_commands = false
		22 |   app_name           = var.networking[0].application
		23 |   business_unit      = local.vpc_name
		24 |   subnet_set         = local.subnet_set
		25 |   environment        = local.environment
		26 |   region             = "eu-west-2"
		27 | 
		28 |   # Tags
		29 |   tags_common = local.tags
		30 |   tags_prefix = terraform.workspace
		31 | }

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: pagerduty_core_alerts_non_prod
	File: /ecs.tf:480-488
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		480 | module "pagerduty_core_alerts_non_prod" {
		481 |   count = local.is-preproduction ? 1 : 0
		482 |   depends_on = [
		483 |     aws_sns_topic.ncas_utilisation_alarm
		484 |   ]
		485 |   source                    = "github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=v2.0.0"
		486 |   sns_topics                = [aws_sns_topic.ncas_utilisation_alarm[0].name]
		487 |   pagerduty_integration_key = local.pagerduty_integration_keys["ncas_non_prod_alarms"]
		488 | }

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: pagerduty_core_alerts_prod
	File: /ecs.tf:491-499
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		491 | module "pagerduty_core_alerts_prod" {
		492 |   count = local.is-production ? 1 : 0
		493 |   depends_on = [
		494 |     aws_sns_topic.ncas_utilisation_alarm
		495 |   ]
		496 |   source                    = "github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=v2.0.0"
		497 |   sns_topics                = [aws_sns_topic.ncas_utilisation_alarm[0].name]
		498 |   pagerduty_integration_key = local.pagerduty_integration_keys["ncas_prod_alarms"]
		499 | }

Check: CKV_AWS_158: "Ensure that CloudWatch Log Group is encrypted by KMS"
	FAILED for resource: aws_cloudwatch_log_group.deployment_logs
	File: /ecs.tf:9-12
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-that-cloudwatch-log-group-is-encrypted-by-kms

		9  | resource "aws_cloudwatch_log_group" "deployment_logs" {
		10 |   name              = "/aws/events/deploymentLogs"
		11 |   retention_in_days = "7"
		12 | }

Check: CKV_AWS_158: "Ensure that CloudWatch Log Group is encrypted by KMS"
	FAILED for resource: aws_cloudwatch_log_group.ecs_logs
	File: /ecs.tf:14-17
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-that-cloudwatch-log-group-is-encrypted-by-kms

		14 | resource "aws_cloudwatch_log_group" "ecs_logs" {
		15 |   name              = "ncas-ecs"
		16 |   retention_in_days = "7"
		17 | }

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: aws_iam_role_policy.app_execution
	File: /ecs.tf:257-280
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-290

		257 | resource "aws_iam_role_policy" "app_execution" {
		258 |   name = "execution-${var.networking[0].application}"
		259 |   role = aws_iam_role.app_execution.id
		260 | 
		261 |   policy = <<-EOF
		262 |   {
		263 |     "Version": "2012-10-17",
		264 |     "Statement": [
		265 |       {
		266 |            "Action": [
		267 |               "ecr:*",
		268 |               "logs:CreateLogGroup",
		269 |               "logs:CreateLogStream",
		270 |               "logs:PutLogEvents",
		271 |               "logs:DescribeLogStreams",
		272 |               "secretsmanager:GetSecretValue"
		273 |            ],
		274 |            "Resource": "*",
		275 |            "Effect": "Allow"
		276 |       }
		277 |     ]
		278 |   }
		279 |   EOF
		280 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: aws_iam_role_policy.app_execution
	File: /ecs.tf:257-280
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-289

		257 | resource "aws_iam_role_policy" "app_execution" {
		258 |   name = "execution-${var.networking[0].application}"
		259 |   role = aws_iam_role.app_execution.id
		260 | 
		261 |   policy = <<-EOF
		262 |   {
		263 |     "Version": "2012-10-17",
		264 |     "Statement": [
		265 |       {
		266 |            "Action": [
		267 |               "ecr:*",
		268 |               "logs:CreateLogGroup",
		269 |               "logs:CreateLogStream",
		270 |               "logs:PutLogEvents",
		271 |               "logs:DescribeLogStreams",
		272 |               "secretsmanager:GetSecretValue"
		273 |            ],
		274 |            "Resource": "*",
		275 |            "Effect": "Allow"
		276 |       }
		277 |     ]
		278 |   }
		279 |   EOF
		280 | }

Check: CKV_AWS_288: "Ensure IAM policies does not allow data exfiltration"
	FAILED for resource: aws_iam_role_policy.app_execution
	File: /ecs.tf:257-280
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-288

		257 | resource "aws_iam_role_policy" "app_execution" {
		258 |   name = "execution-${var.networking[0].application}"
		259 |   role = aws_iam_role.app_execution.id
		260 | 
		261 |   policy = <<-EOF
		262 |   {
		263 |     "Version": "2012-10-17",
		264 |     "Statement": [
		265 |       {
		266 |            "Action": [
		267 |               "ecr:*",
		268 |               "logs:CreateLogGroup",
		269 |               "logs:CreateLogStream",
		270 |               "logs:PutLogEvents",
		271 |               "logs:DescribeLogStreams",
		272 |               "secretsmanager:GetSecretValue"
		273 |            ],
		274 |            "Resource": "*",
		275 |            "Effect": "Allow"
		276 |       }
		277 |     ]
		278 |   }
		279 |   EOF
		280 | }

Check: CKV_AWS_355: "Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions"
	FAILED for resource: aws_iam_role_policy.app_execution
	File: /ecs.tf:257-280
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-355

		257 | resource "aws_iam_role_policy" "app_execution" {
		258 |   name = "execution-${var.networking[0].application}"
		259 |   role = aws_iam_role.app_execution.id
		260 | 
		261 |   policy = <<-EOF
		262 |   {
		263 |     "Version": "2012-10-17",
		264 |     "Statement": [
		265 |       {
		266 |            "Action": [
		267 |               "ecr:*",
		268 |               "logs:CreateLogGroup",
		269 |               "logs:CreateLogStream",
		270 |               "logs:PutLogEvents",
		271 |               "logs:DescribeLogStreams",
		272 |               "secretsmanager:GetSecretValue"
		273 |            ],
		274 |            "Resource": "*",
		275 |            "Effect": "Allow"
		276 |       }
		277 |     ]
		278 |   }
		279 |   EOF
		280 | }

Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-290

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }

Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-289

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }

Check: CKV_AWS_287: "Ensure IAM policies does not allow credentials exposure"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-287

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }

Check: CKV_AWS_286: "Ensure IAM policies does not allow privilege escalation"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-286

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }

Check: CKV_AWS_355: "Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-355

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }

Check: CKV_AWS_23: "Ensure every security group and rule has a description"
	FAILED for resource: aws_security_group.ecs_service
	File: /ecs.tf:333-351
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/networking-31

		333 | resource "aws_security_group" "ecs_service" {
		334 |   name_prefix = "ecs-service-sg-"
		335 |   vpc_id      = data.aws_vpc.shared.id
		336 | 
		337 |   ingress {
		338 |     from_port       = 80
		339 |     to_port         = 80
		340 |     protocol        = "tcp"
		341 |     description     = "Allow traffic on port 80 from load balancer"
		342 |     security_groups = [aws_security_group.ncas_lb_sc.id]
		343 |   }
		344 | 
		345 |   egress {
		346 |     from_port   = 0
		347 |     to_port     = 0
		348 |     protocol    = "-1"
		349 |     cidr_blocks = ["0.0.0.0/0"]
		350 |   }
		351 | }

Check: CKV_AWS_136: "Ensure that ECR repositories are encrypted using KMS"
	FAILED for resource: aws_ecr_repository.ncas_ecr_repo
	File: /ecs.tf:353-356
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-that-ecr-repositories-are-encrypted

		353 | resource "aws_ecr_repository" "ncas_ecr_repo" {
		354 |   name         = "ncas-ecr-repo"
		355 |   force_delete = true
		356 | }

Check: CKV_AWS_163: "Ensure ECR image scanning on push is enabled"
	FAILED for resource: aws_ecr_repository.ncas_ecr_repo
	File: /ecs.tf:353-356
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-8

		353 | resource "aws_ecr_repository" "ncas_ecr_repo" {
		354 |   name         = "ncas-ecr-repo"
		355 |   force_delete = true
		356 | }

Check: CKV_AWS_51: "Ensure ECR Image Tags are immutable"
	FAILED for resource: aws_ecr_repository.ncas_ecr_repo
	File: /ecs.tf:353-356
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-general-24

		353 | resource "aws_ecr_repository" "ncas_ecr_repo" {
		354 |   name         = "ncas-ecr-repo"
		355 |   force_delete = true
		356 | }

Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	FAILED for resource: aws_sns_topic.ddos_alarm
	File: /ecs.tf:452-455
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-15

		452 | resource "aws_sns_topic" "ddos_alarm" {
		453 |   count = local.is-development ? 0 : 1
		454 |   name  = "ncas_ddos_alarm"
		455 | }

Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	FAILED for resource: aws_sns_topic.ncas_utilisation_alarm
	File: /ecs.tf:457-460
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-15

		457 | resource "aws_sns_topic" "ncas_utilisation_alarm" {
		458 |   count = local.is-development ? 0 : 1
		459 |   name  = "ncas_utilisation_alarm"
		460 | }

Check: CKV_AWS_23: "Ensure every security group and rule has a description"
	FAILED for resource: aws_security_group.ncas_lb_sc
	File: /load_balancer.tf:1-87
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/networking-31

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
Check: CKV_AWS_23: "Ensure every security group and rule has a description"
	FAILED for resource: aws_security_group.lb_sc_pingdom
	File: /load_balancer.tf:89-160
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/networking-31

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
Check: CKV_AWS_23: "Ensure every security group and rule has a description"
	FAILED for resource: aws_security_group.lb_sc_pingdom_2
	File: /load_balancer.tf:162-233
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/networking-31

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
Check: CKV_AWS_91: "Ensure the ELBv2 (Application/Network) has access logging enabled"
	FAILED for resource: aws_lb.ncas_lb
	File: /load_balancer.tf:235-243
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/bc-aws-logging-22

		235 | resource "aws_lb" "ncas_lb" {
		236 |   name                       = "ncas-load-balancer"
		237 |   load_balancer_type         = "application"
		238 |   security_groups            = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
		239 |   subnets                    = data.aws_subnets.shared-public.ids
		240 |   enable_deletion_protection = false
		241 |   internal                   = false
		242 |   depends_on                 = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
		243 | }

Check: CKV_AWS_131: "Ensure that ALB drops HTTP headers"
	FAILED for resource: aws_lb.ncas_lb
	File: /load_balancer.tf:235-243
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/ensure-that-alb-drops-http-headers

		235 | resource "aws_lb" "ncas_lb" {
		236 |   name                       = "ncas-load-balancer"
		237 |   load_balancer_type         = "application"
		238 |   security_groups            = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
		239 |   subnets                    = data.aws_subnets.shared-public.ids
		240 |   enable_deletion_protection = false
		241 |   internal                   = false
		242 |   depends_on                 = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
		243 | }

Check: CKV_AWS_150: "Ensure that Load Balancer has deletion protection enabled"
	FAILED for resource: aws_lb.ncas_lb
	File: /load_balancer.tf:235-243
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-150

		235 | resource "aws_lb" "ncas_lb" {
		236 |   name                       = "ncas-load-balancer"
		237 |   load_balancer_type         = "application"
		238 |   security_groups            = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
		239 |   subnets                    = data.aws_subnets.shared-public.ids
		240 |   enable_deletion_protection = false
		241 |   internal                   = false
		242 |   depends_on                 = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
		243 | }

Check: CKV_AWS_261: "Ensure HTTP HTTPS Target group defines Healthcheck"
	FAILED for resource: aws_lb_target_group.ncas_target_group
	File: /load_balancer.tf:245-267
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-aws-kendra-index-server-side-encryption-uses-customer-managed-keys-cmks

		245 | resource "aws_lb_target_group" "ncas_target_group" {
		246 |   name                 = "ncas-target-group"
		247 |   port                 = 80
		248 |   protocol             = "HTTP"
		249 |   vpc_id               = data.aws_vpc.shared.id
		250 |   target_type          = "ip"
		251 |   deregistration_delay = 30
		252 | 
		253 |   stickiness {
		254 |     type = "lb_cookie"
		255 |   }
		256 | 
		257 |   health_check {
		258 |     healthy_threshold   = "3"
		259 |     interval            = "30"
		260 |     protocol            = "HTTP"
		261 |     port                = "80"
		262 |     unhealthy_threshold = "5"
		263 |     matcher             = "200-302"
		264 |     timeout             = "10"
		265 |   }
		266 | 
		267 | }

Check: CKV_AWS_2: "Ensure ALB protocol is HTTPS"
	FAILED for resource: aws_lb_listener.ncas_lb
	File: /load_balancer.tf:269-283
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/networking-29

		269 | resource "aws_lb_listener" "ncas_lb" {
		270 |   depends_on = [
		271 |     aws_acm_certificate.external
		272 |   ]
		273 |   certificate_arn   = local.is-production ? aws_acm_certificate.external_prod[0].arn : aws_acm_certificate.external.arn
		274 |   load_balancer_arn = aws_lb.ncas_lb.arn
		275 |   port              = local.application_data.accounts[local.environment].server_port_2
		276 |   protocol          = local.application_data.accounts[local.environment].lb_listener_protocol_2
		277 |   ssl_policy        = local.application_data.accounts[local.environment].lb_listener_protocol_2 == "HTTP" ? "" : "ELBSecurityPolicy-TLS13-1-2-2021-06"
		278 | 
		279 |   default_action {
		280 |     type             = "forward"
		281 |     target_group_arn = aws_lb_target_group.ncas_target_group.arn
		282 |   }
		283 | }

Check: CKV_AWS_16: "Ensure all data stored in the RDS is securely encrypted at rest"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-4

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_157: "Ensure that RDS instances have Multi-AZ enabled"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-73

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_118: "Ensure that enhanced monitoring is enabled for Amazon RDS instances"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/ensure-that-enhanced-monitoring-is-enabled-for-amazon-rds-instances

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_353: "Ensure that RDS instances have performance insights enabled"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/bc-aws-353

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_354: "Ensure RDS Performance Insights are encrypted using KMS CMKs"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-354

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_226: "Ensure DB instance gets all minor upgrades automatically"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-aws-db-instance-gets-all-minor-upgrades-automatically

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_129: "Ensure that respective logs of Amazon Relational Database Service (Amazon RDS) are enabled"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/ensure-that-respective-logs-of-amazon-relational-database-service-amazon-rds-are-enabled

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_293: "Ensure that AWS database instances have deletion protection enabled"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-293

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV_AWS_16: "Ensure all data stored in the RDS is securely encrypted at rest"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-4

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_157: "Ensure that RDS instances have Multi-AZ enabled"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/general-73

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_118: "Ensure that enhanced monitoring is enabled for Amazon RDS instances"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/ensure-that-enhanced-monitoring-is-enabled-for-amazon-rds-instances

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_353: "Ensure that RDS instances have performance insights enabled"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/bc-aws-353

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_354: "Ensure RDS Performance Insights are encrypted using KMS CMKs"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-354

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_17: "Ensure all data stored in RDS is not publicly accessible"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/public-policies/public-2

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_226: "Ensure DB instance gets all minor upgrades automatically"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-aws-db-instance-gets-all-minor-upgrades-automatically

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_129: "Ensure that respective logs of Amazon Relational Database Service (Amazon RDS) are enabled"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/ensure-that-respective-logs-of-amazon-relational-database-service-amazon-rds-are-enabled

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_293: "Ensure that AWS database instances have deletion protection enabled"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-293

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_149: "Ensure that Secrets Manager secret is encrypted using KMS CMK"
	FAILED for resource: aws_secretsmanager_secret.rds_db_credentials
	File: /secrets.tf:11-14
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/ensure-that-secrets-manager-secret-is-encrypted-using-kms

		11 | resource "aws_secretsmanager_secret" "rds_db_credentials" {
		12 |   name                    = "rds-password"
		13 |   recovery_window_in_days = 0
		14 | }

Check: CKV_AWS_192: "Ensure WAF prevents message lookup in Log4j2. See CVE-2021-44228 aka log4jshell"
	FAILED for resource: aws_wafv2_web_acl.ncas_web_acl
	File: /waf.tf:1-36
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-networking-policies/ensure-waf-prevents-message-lookup-in-log4j2

		1  | resource "aws_wafv2_web_acl" "ncas_web_acl" {
		2  |   name  = "ncas-web-acl"
		3  |   scope = "REGIONAL"
		4  | 
		5  |   default_action {
		6  |     allow {}
		7  |   }
		8  | 
		9  |   rule {
		10 |     name     = "common-rule-set"
		11 |     priority = 1
		12 | 
		13 |     override_action {
		14 |       none {}
		15 |     }
		16 | 
		17 |     statement {
		18 |       managed_rule_group_statement {
		19 |         name        = "AWSManagedRulesCommonRuleSet"
		20 |         vendor_name = "AWS"
		21 |       }
		22 |     }
		23 | 
		24 |     visibility_config {
		25 |       cloudwatch_metrics_enabled = true
		26 |       metric_name                = "AWSManagedRulesCommonRuleSetMetrics"
		27 |       sampled_requests_enabled   = true
		28 |     }
		29 |   }
		30 | 
		31 |   visibility_config {
		32 |     cloudwatch_metrics_enabled = true
		33 |     metric_name                = "ncas-web-acl"
		34 |     sampled_requests_enabled   = true
		35 |   }
		36 | }
Check: CKV2_AWS_57: "Ensure Secrets Manager secrets should have automatic rotation enabled"
	FAILED for resource: aws_secretsmanager_secret.rds_db_credentials
	File: /secrets.tf:11-14
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-2-57

		11 | resource "aws_secretsmanager_secret" "rds_db_credentials" {
		12 |   name                    = "rds-password"
		13 |   recovery_window_in_days = 0
		14 | }

Check: CKV2_AWS_31: "Ensure WAF2 has a Logging Configuration"
	FAILED for resource: aws_wafv2_web_acl.ncas_web_acl
	File: /waf.tf:1-36
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-logging-policies/bc-aws-logging-33

		1  | resource "aws_wafv2_web_acl" "ncas_web_acl" {
		2  |   name  = "ncas-web-acl"
		3  |   scope = "REGIONAL"
		4  | 
		5  |   default_action {
		6  |     allow {}
		7  |   }
		8  | 
		9  |   rule {
		10 |     name     = "common-rule-set"
		11 |     priority = 1
		12 | 
		13 |     override_action {
		14 |       none {}
		15 |     }
		16 | 
		17 |     statement {
		18 |       managed_rule_group_statement {
		19 |         name        = "AWSManagedRulesCommonRuleSet"
		20 |         vendor_name = "AWS"
		21 |       }
		22 |     }
		23 | 
		24 |     visibility_config {
		25 |       cloudwatch_metrics_enabled = true
		26 |       metric_name                = "AWSManagedRulesCommonRuleSetMetrics"
		27 |       sampled_requests_enabled   = true
		28 |     }
		29 |   }
		30 | 
		31 |   visibility_config {
		32 |     cloudwatch_metrics_enabled = true
		33 |     metric_name                = "ncas-web-acl"
		34 |     sampled_requests_enabled   = true
		35 |   }
		36 | }
Check: CKV2_AWS_60: "Ensure RDS instance with copy tags to snapshots is enabled"
	FAILED for resource: aws_db_instance.ncas_db
	File: /rds.tf:1-19
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-2-60

		1  | resource "aws_db_instance" "ncas_db" {
		2  |   count                       = local.is-development ? 0 : 1
		3  |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		4  |   db_name                     = local.application_data.accounts[local.environment].db_name
		5  |   storage_type                = local.application_data.accounts[local.environment].storage_type
		6  |   engine                      = local.application_data.accounts[local.environment].engine
		7  |   identifier                  = local.application_data.accounts[local.environment].identifier
		8  |   engine_version              = local.application_data.accounts[local.environment].engine_version
		9  |   instance_class              = local.application_data.accounts[local.environment].instance_class
		10 |   username                    = local.application_data.accounts[local.environment].db_username
		11 |   password                    = random_password.password.result
		12 |   skip_final_snapshot         = true
		13 |   publicly_accessible         = false
		14 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc[0].id]
		15 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		16 |   allow_major_version_upgrade = true
		17 |   ca_cert_identifier          = "rds-ca-rsa2048-g1"
		18 |   apply_immediately           = true
		19 | }

Check: CKV2_AWS_60: "Ensure RDS instance with copy tags to snapshots is enabled"
	FAILED for resource: aws_db_instance.ncas_db_dev
	File: /rds.tf:65-81
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-2-60

		65 | resource "aws_db_instance" "ncas_db_dev" {
		66 |   count                       = local.is-development ? 1 : 0
		67 |   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
		68 |   db_name                     = local.application_data.accounts[local.environment].db_name
		69 |   storage_type                = local.application_data.accounts[local.environment].storage_type
		70 |   engine                      = local.application_data.accounts[local.environment].engine
		71 |   identifier                  = local.application_data.accounts[local.environment].identifier
		72 |   engine_version              = local.application_data.accounts[local.environment].engine_version
		73 |   instance_class              = local.application_data.accounts[local.environment].instance_class
		74 |   username                    = local.application_data.accounts[local.environment].db_username
		75 |   password                    = random_password.password.result
		76 |   skip_final_snapshot         = true
		77 |   publicly_accessible         = true
		78 |   vpc_security_group_ids      = [aws_security_group.postgresql_db_sc_dev[0].id]
		79 |   db_subnet_group_name        = aws_db_subnet_group.dbsubnetgroup.name
		80 |   allow_major_version_upgrade = true
		81 | }

Check: CKV_AWS_103: "Ensure that load balancer is using at least TLS 1.2"
	FAILED for resource: aws_lb_listener.ncas_lb
	File: /load_balancer.tf:269-283
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-general-policies/bc-aws-general-43

		269 | resource "aws_lb_listener" "ncas_lb" {
		270 |   depends_on = [
		271 |     aws_acm_certificate.external
		272 |   ]
		273 |   certificate_arn   = local.is-production ? aws_acm_certificate.external_prod[0].arn : aws_acm_certificate.external.arn
		274 |   load_balancer_arn = aws_lb.ncas_lb.arn
		275 |   port              = local.application_data.accounts[local.environment].server_port_2
		276 |   protocol          = local.application_data.accounts[local.environment].lb_listener_protocol_2
		277 |   ssl_policy        = local.application_data.accounts[local.environment].lb_listener_protocol_2 == "HTTP" ? "" : "ELBSecurityPolicy-TLS13-1-2-2021-06"
		278 | 
		279 |   default_action {
		280 |     type             = "forward"
		281 |     target_group_arn = aws_lb_target_group.ncas_target_group.arn
		282 |   }
		283 | }

Check: CKV2_AWS_40: "Ensure AWS IAM policy does not allow full IAM privileges"
	FAILED for resource: aws_iam_role_policy.app_task
	File: /ecs.tf:309-331
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/bc-aws-2-40

		309 | resource "aws_iam_role_policy" "app_task" {
		310 |   name = "task-${var.networking[0].application}"
		311 |   role = aws_iam_role.app_task.id
		312 | 
		313 |   policy = <<-EOF
		314 |   {
		315 |    "Version": "2012-10-17",
		316 |    "Statement": [
		317 |      {
		318 |        "Effect": "Allow",
		319 |         "Action": [
		320 |           "logs:CreateLogStream",
		321 |           "logs:PutLogEvents",
		322 |           "ecr:*",
		323 |           "iam:*",
		324 |           "ec2:*"
		325 |         ],
		326 |        "Resource": "*"
		327 |      }
		328 |    ]
		329 |   }
		330 |   EOF
		331 | }


checkov_exitcode=1

CTFLint Scan Failed

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/ncas

*****************************

Running tflint in terraform/environments/ncas
Excluding the following checks: terraform_unused_declarations
20 issue(s) found:

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 54:
  54:           value = "${aws_db_instance.ncas_db[0].address}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 58:
  58:           value = "${local.application_data.accounts[local.environment].rds_port}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 62:
  62:           value = "${aws_db_instance.ncas_db[0].username}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 66:
  66:           value = "${aws_db_instance.ncas_db[0].password}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 70:
  70:           value = "${aws_db_instance.ncas_db[0].db_name}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 74:
  74:           value = "${local.application_data.accounts[local.environment].support_email}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 78:
  78:           value = "${local.application_data.accounts[local.environment].support_team}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 82:
  82:           value = "${local.application_data.accounts[local.environment].client_id}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 129:
 129:           value = "${aws_db_instance.ncas_db_dev[0].address}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 133:
 133:           value = "${local.application_data.accounts[local.environment].rds_port}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 137:
 137:           value = "${aws_db_instance.ncas_db_dev[0].username}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 141:
 141:           value = "${aws_db_instance.ncas_db_dev[0].password}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 145:
 145:           value = "${aws_db_instance.ncas_db_dev[0].db_name}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 149:
 149:           value = "${local.application_data.accounts[local.environment].support_email}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 153:
 153:           value = "${local.application_data.accounts[local.environment].support_team}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/ecs.tf line 157:
 157:           value = "${local.application_data.accounts[local.environment].client_id}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: Missing version constraint for provider "null" in `required_providers` (terraform_required_providers)

  on terraform/environments/ncas/rds.tf line 126:
 126: resource "null_resource" "setup_dev_db" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_required_providers.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/rds.tf line 143:
 143:     always_run = "${timestamp()}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

Warning: Missing version constraint for provider "random" in `required_providers` (terraform_required_providers)

  on terraform/environments/ncas/secrets.tf line 2:
   2: resource "random_password" "password" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_required_providers.md

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/environments/ncas/secrets.tf line 18:
  18:   secret_string = jsonencode({ "NCAS_DB_PASSWORD" : "${random_password.password.result}" })

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

tflint_exitcode=2

Trivy Scan Failed

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/ncas

*****************************

Running Trivy in terraform/environments/ncas
2024-07-09T15:10:54Z	INFO	Need to update DB
2024-07-09T15:10:54Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-09T15:10:55Z	INFO	Vulnerability scanning is enabled
2024-07-09T15:10:55Z	INFO	Misconfiguration scanning is enabled
2024-07-09T15:10:55Z	INFO	Need to update the built-in policies
2024-07-09T15:10:55Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-09T15:10:56Z	INFO	Secret scanning is enabled
2024-07-09T15:10:56Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-09T15:10:56Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-09T15:10:57Z	INFO	Number of language-specific files	num=0
2024-07-09T15:10:57Z	INFO	Detected config files	num=7

ecs.tf (terraform)
==================
Tests: 14 (SUCCESSES: 3, FAILURES: 4, EXCEPTIONS: 7)
Failures: 4 (HIGH: 3, CRITICAL: 1)

HIGH: Image scanning is not enabled.
════════════════════════════════════════
Repository image scans should be enabled to ensure vulnerable software can be discovered and remediated as soon as possible.

See https://avd.aquasec.com/misconfig/avd-aws-0030
────────────────────────────────────────
 ecs.tf:353-356
────────────────────────────────────────
 353 ┌ resource "aws_ecr_repository" "ncas_ecr_repo" {
 354 │   name         = "ncas-ecr-repo"
 355 │   force_delete = true
 356 └ }
────────────────────────────────────────


HIGH: Topic does not have encryption enabled.
════════════════════════════════════════
Topics should be encrypted to protect their contents.

See https://avd.aquasec.com/misconfig/avd-aws-0095
────────────────────────────────────────
 ecs.tf:452-455
────────────────────────────────────────
 452 ┌ resource "aws_sns_topic" "ddos_alarm" {
 453 │   count = local.is-development ? 0 : 1
 454 │   name  = "ncas_ddos_alarm"
 455 └ }
────────────────────────────────────────


HIGH: Topic does not have encryption enabled.
════════════════════════════════════════
Topics should be encrypted to protect their contents.

See https://avd.aquasec.com/misconfig/avd-aws-0095
────────────────────────────────────────
 ecs.tf:457-460
────────────────────────────────────────
 457 ┌ resource "aws_sns_topic" "ncas_utilisation_alarm" {
 458 │   count = local.is-development ? 0 : 1
 459 │   name  = "ncas_utilisation_alarm"
 460 └ }
────────────────────────────────────────


CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
 ecs.tf:349
   via ecs.tf:345-350 (egress)
    via ecs.tf:333-351 (aws_security_group.ecs_service)
────────────────────────────────────────
 333   resource "aws_security_group" "ecs_service" {
 ...   
 349 [     cidr_blocks = ["0.0.0.0/0"]
 ...   
 351   }
────────────────────────────────────────



github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux?ref=v4.2.1/main.tf (terraform)
==========================================================================================================
Tests: 16 (SUCCESSES: 5, FAILURES: 0, EXCEPTIONS: 11)
Failures: 0 (HIGH: 0, CRITICAL: 0)


load_balancer.tf (terraform)
============================
Tests: 12 (SUCCESSES: 6, FAILURES: 6, EXCEPTIONS: 0)
Failures: 6 (HIGH: 2, CRITICAL: 4)

HIGH: Application load balancer is not set to drop invalid headers.
════════════════════════════════════════
Passing unknown or invalid headers through to the target poses a potential risk of compromise. 

By setting drop_invalid_header_fields to true, anything that doe not conform to well known, defined headers will be removed by the load balancer.

See https://avd.aquasec.com/misconfig/avd-aws-0052
────────────────────────────────────────
 load_balancer.tf:235-243
────────────────────────────────────────
 235 ┌ resource "aws_lb" "ncas_lb" {
 236 │   name                       = "ncas-load-balancer"
 237 │   load_balancer_type         = "application"
 238 │   security_groups            = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
 239 │   subnets                    = data.aws_subnets.shared-public.ids
 240 │   enable_deletion_protection = false
 241 │   internal                   = false
 242 │   depends_on                 = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
 243 └ }
────────────────────────────────────────


HIGH: Load balancer is exposed publicly.
════════════════════════════════════════
There are many scenarios in which you would want to expose a load balancer to the wider internet, but this check exists as a warning to prevent accidental exposure of internal assets. You should ensure that this resource should be exposed publicly.

See https://avd.aquasec.com/misconfig/avd-aws-0053
────────────────────────────────────────
 load_balancer.tf:241
   via load_balancer.tf:235-243 (aws_lb.ncas_lb)
────────────────────────────────────────
 235   resource "aws_lb" "ncas_lb" {
 236     name                       = "ncas-load-balancer"
 237     load_balancer_type         = "application"
 238     security_groups            = [aws_security_group.ncas_lb_sc.id, aws_security_group.lb_sc_pingdom.id, aws_security_group.lb_sc_pingdom_2.id]
 239     subnets                    = data.aws_subnets.shared-public.ids
 240     enable_deletion_protection = false
 241 [   internal                   = false
 242     depends_on                 = [aws_security_group.ncas_lb_sc, aws_security_group.lb_sc_pingdom, aws_security_group.lb_sc_pingdom_2]
 243   }
────────────────────────────────────────


CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
 load_balancer.tf:85
   via load_balancer.tf:80-86 (egress)
    via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
   1   resource "aws_security_group" "ncas_lb_sc" {
   .   
  85 [     cidr_blocks = ["0.0.0.0/0"]
  ..   
  87   }
────────────────────────────────────────


CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
 load_balancer.tf:77
   via load_balancer.tf:72-78 (egress)
    via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
   1   resource "aws_security_group" "ncas_lb_sc" {
   .   
  77 [     cidr_blocks = ["0.0.0.0/0"]
  ..   
  87   }
────────────────────────────────────────


CRITICAL: Security group rule allows ingress from public internet.
════════════════════════════════════════
Opening up ports to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that explicitly require it where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0107
────────────────────────────────────────
 load_balancer.tf:55-69
   via load_balancer.tf:51-70 (ingress)
    via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
   1   resource "aws_security_group" "ncas_lb_sc" {
   .   
  55 ┌     cidr_blocks = [
  56 │       "20.26.11.71/32",
  57 │       "20.26.11.108/32",
  58 │       "20.49.214.199/32",
  59 │       "20.49.214.228/32",
  60 │       "51.149.249.0/29",
  61 └       "51.149.249.32/29",
  ..   
────────────────────────────────────────


CRITICAL: Security group rule allows ingress from public internet.
════════════════════════════════════════
Opening up ports to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that explicitly require it where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0107
────────────────────────────────────────
 load_balancer.tf:27-47
   via load_balancer.tf:23-48 (ingress)
    via load_balancer.tf:1-87 (aws_security_group.ncas_lb_sc)
────────────────────────────────────────
   1   resource "aws_security_group" "ncas_lb_sc" {
   .   
  27 ┌     cidr_blocks = [
  28 │       "194.33.196.0/25",
  29 │       "201.33.21.5/32",
  30 │       "93.56.171.15/32",
  31 │       "194.33.193.0/25",
  32 │       "179.50.12.212/32",
  33 └       "54.94.206.111/32",
  ..   
────────────────────────────────────────



rds.tf (terraform)
==================
Tests: 5 (SUCCESSES: 3, FAILURES: 2, EXCEPTIONS: 0)
Failures: 2 (HIGH: 1, CRITICAL: 1)

HIGH: Instance does not have storage encryption enabled.
════════════════════════════════════════
Encryption should be enabled for an RDS Database instances. 

When enabling encryption by setting the kms_key_id.

See https://avd.aquasec.com/misconfig/avd-aws-0080
────────────────────────────────────────
 rds.tf:1-19
────────────────────────────────────────
   1 ┌ resource "aws_db_instance" "ncas_db" {
   2 │   count                       = local.is-development ? 0 : 1
   3 │   allocated_storage           = local.application_data.accounts[local.environment].allocated_storage
   4 │   db_name                     = local.application_data.accounts[local.environment].db_name
   5 │   storage_type                = local.application_data.accounts[local.environment].storage_type
   6 │   engine                      = local.application_data.accounts[local.environment].engine
   7 │   identifier                  = local.application_data.accounts[local.environment].identifier
   8 │   engine_version              = local.application_data.accounts[local.environment].engine_version
   9 └   instance_class              = local.application_data.accounts[local.environment].instance_class
  ..   
────────────────────────────────────────


CRITICAL: Security group rule allows egress to multiple public internet addresses.
════════════════════════════════════════
Opening up ports to connect out to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that are explicitly required where possible.

See https://avd.aquasec.com/misconfig/avd-aws-0104
────────────────────────────────────────
 rds.tf:60
   via rds.tf:55-61 (egress)
    via rds.tf:26-62 (aws_security_group.postgresql_db_sc[0])
────────────────────────────────────────
  26   resource "aws_security_group" "postgresql_db_sc" {
  ..   
  60 [     cidr_blocks = ["0.0.0.0/0"]
  ..   
  62   }
────────────────────────────────────────


trivy_exitcode=1

@matt-k1998 matt-k1998 merged commit 29c1a4e into main Jul 9, 2024
7 of 11 checks passed
@matt-k1998 matt-k1998 deleted the ncas-update-rds-cert branch July 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewsearle01 matthewsearle01 matthewsearle01 approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-k1998 @matthewsearle01