Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⏫ Increase replica count for create-a-derived-table and airflow #6774

Merged
merged 1 commit into from
Jun 27, 2024
Merged

⏫ Increase replica count for create-a-derived-table and airflow #6774

merged 1 commit into from
Jun 27, 2024

Conversation

jacobwoffenden
Copy link
Member

This pull request:

  • Increases the replica count for create-a-derived-table and airflow now we're pushing more work through them

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Update replica count for cadet and airflow
75a5f4a 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Jun 27, 2024
@jacobwoffenden jacobwoffenden requested review from a team as code owners June 27, 2024 14:17
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-27T14:20:38Z INFO Need to update DB
2024-06-27T14:20:38Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-27T14:20:40Z INFO Vulnerability scanning is enabled
2024-06-27T14:20:40Z INFO Misconfiguration scanning is enabled
2024-06-27T14:20:40Z INFO Need to update the built-in policies
2024-06-27T14:20:40Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-27T14:20:41Z INFO Secret scanning is enabled
2024-06-27T14:20:41Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-27T14:20:41Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-27T14:21:08Z INFO Number of language-specific files num=0
2024-06-27T14:21:08Z INFO Detected config files num=18

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=73b752a1e365808a7214f064845e958e65c548bd/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=73b752a1e365808a7214f064845e958e65c548bd/modules/karpenter/main.tf (terraform)

Tests: 8 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)

Tests: 25 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 25)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam-policies.tf (terraform)

Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-27 14:21:11,358 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.2.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,358 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,358 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-github-oidc-role:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.14.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws//modules/karpenter:20.14.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/rds/aws:6.7.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,359 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,360 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,360 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,360 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,360 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.4.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,360 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,361 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,361 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-27 14:21:11,361 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 83, Failed checks: 0, Skipped checks: 88


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-27T14:20:38Z	INFO	Need to update DB
2024-06-27T14:20:38Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-27T14:20:40Z	INFO	Vulnerability scanning is enabled
2024-06-27T14:20:40Z	INFO	Misconfiguration scanning is enabled
2024-06-27T14:20:40Z	INFO	Need to update the built-in policies
2024-06-27T14:20:40Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-27T14:20:41Z	INFO	Secret scanning is enabled
2024-06-27T14:20:41Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-27T14:20:41Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-27T14:21:08Z	INFO	Number of language-specific files	num=0
2024-06-27T14:21:08Z	INFO	Detected config files	num=18

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=73b752a1e365808a7214f064845e958e65c548bd/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=73b752a1e365808a7214f064845e958e65c548bd/modules/karpenter/main.tf (terraform)
=================================================================================================================================================
Tests: 8 (SUCCESSES: 3, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)
=============================================================================================================================================================================
Tests: 25 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 25)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam-policies.tf (terraform)
===========================
Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

Gary-H9
Gary-H9 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit b56ccea into main Jun 27, 2024
14 checks passed
@jacobwoffenden jacobwoffenden deleted the chore/apc-runner-replicas branch June 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9