Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Add ACL permissions to Destination Bucket #6060

Merged
merged 2 commits into from
May 13, 2024
Merged

🔧 Add ACL permissions to Destination Bucket #6060

merged 2 commits into from
May 13, 2024

Conversation

Gary-H9
Copy link
Contributor

@Gary-H9 Gary-H9 commented May 13, 2024 •
edited
Loading

This PR resolves the bug described in this issue.

@Gary-H9 Gary-H9 requested review from a team as code owners May 13, 2024 15:27
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label May 13, 2024
@Gary-H9 Gary-H9 had a problem deploying to analytical-platform-ingestion-development May 13, 2024 15:28 — with GitHub Actions Failure
@Gary-H9 Gary-H9 had a problem deploying to analytical-platform-ingestion-development May 13, 2024 15:29 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-05-13T15:29:17Z INFO Need to update DB
2024-05-13T15:29:17Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-13T15:29:18Z INFO Vulnerability scanning is enabled
2024-05-13T15:29:18Z INFO Misconfiguration scanning is enabled
2024-05-13T15:29:18Z INFO Need to update the built-in policies
2024-05-13T15:29:18Z INFO Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-13T15:29:19Z INFO Secret scanning is enabled
2024-05-13T15:29:19Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-13T15:29:19Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-13T15:29:25Z INFO Number of language-specific files num=0
2024-05-13T15:29:25Z INFO Detected config files num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-lambda?ref=c42e75877ec6eed0e2142f7724aa661cffbb5cb8/iam.tf (terraform)

Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

terraform-aws-modules/lambda/aws/iam.tf (terraform)

Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Checkov in terraform/environments/analytical-platform-ingestion
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-05-13 15:29:27,591 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/sns/aws:6.0.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,591 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.37.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,591 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:5.37.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,591 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/lambda/aws:7.2.5 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,592 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.0.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,593 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:2.2.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:29:27,593 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws//modules/notification:4.1.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 102, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running tflint in terraform/environments/analytical-platform-ingestion
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-05-13T15:29:17Z	INFO	Need to update DB
2024-05-13T15:29:17Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-13T15:29:18Z	INFO	Vulnerability scanning is enabled
2024-05-13T15:29:18Z	INFO	Misconfiguration scanning is enabled
2024-05-13T15:29:18Z	INFO	Need to update the built-in policies
2024-05-13T15:29:18Z	INFO	Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-13T15:29:19Z	INFO	Secret scanning is enabled
2024-05-13T15:29:19Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-13T15:29:19Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-13T15:29:25Z	INFO	Number of language-specific files	num=0
2024-05-13T15:29:25Z	INFO	Detected config files	num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-lambda?ref=c42e75877ec6eed0e2142f7724aa661cffbb5cb8/iam.tf (terraform)
=================================================================================================================================
Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


terraform-aws-modules/lambda/aws/iam.tf (terraform)
===================================================
Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@jacobwoffenden jacobwoffenden mentioned this pull request May 13, 2024
Closed
@jacobwoffenden jacobwoffenden self-requested a review May 13, 2024 15:30
jacobwoffenden
jacobwoffenden requested changes May 13, 2024
View reviewed changes
Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump transfer image to 0.0.10 please

@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-05-13T15:54:03Z INFO Need to update DB
2024-05-13T15:54:03Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-13T15:54:05Z INFO Vulnerability scanning is enabled
2024-05-13T15:54:05Z INFO Misconfiguration scanning is enabled
2024-05-13T15:54:05Z INFO Need to update the built-in policies
2024-05-13T15:54:05Z INFO Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-13T15:54:05Z INFO Secret scanning is enabled
2024-05-13T15:54:05Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-13T15:54:05Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-13T15:54:12Z INFO Number of language-specific files num=0
2024-05-13T15:54:12Z INFO Detected config files num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-lambda?ref=c42e75877ec6eed0e2142f7724aa661cffbb5cb8/iam.tf (terraform)

Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

terraform-aws-modules/lambda/aws/iam.tf (terraform)

Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Checkov in terraform/environments/analytical-platform-ingestion
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/sns/aws:6.0.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.37.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:5.37.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:~> 5.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,813 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/lambda/aws:7.2.5 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,814 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.0.0 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,814 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:2.2.1 (for external modules, the --download-external-modules flag is required)
2024-05-13 15:54:14,814 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws//modules/notification:4.1.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 102, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running tflint in terraform/environments/analytical-platform-ingestion
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-ingestion

*****************************

Running Trivy in terraform/environments/analytical-platform-ingestion
2024-05-13T15:54:03Z	INFO	Need to update DB
2024-05-13T15:54:03Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-13T15:54:05Z	INFO	Vulnerability scanning is enabled
2024-05-13T15:54:05Z	INFO	Misconfiguration scanning is enabled
2024-05-13T15:54:05Z	INFO	Need to update the built-in policies
2024-05-13T15:54:05Z	INFO	Downloading the built-in policies...
50.41 KiB / 50.41 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-13T15:54:05Z	INFO	Secret scanning is enabled
2024-05-13T15:54:05Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-13T15:54:05Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-13T15:54:12Z	INFO	Number of language-specific files	num=0
2024-05-13T15:54:12Z	INFO	Detected config files	num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-lambda?ref=c42e75877ec6eed0e2142f7724aa661cffbb5cb8/iam.tf (terraform)
=================================================================================================================================
Tests: 4 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


terraform-aws-modules/lambda/aws/iam.tf (terraform)
===================================================
Tests: 8 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 8)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@Gary-H9 Gary-H9 merged commit c207aec into main May 13, 2024
12 checks passed
@Gary-H9 Gary-H9 deleted the lambda-permissions branch May 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwoffenden jacobwoffenden jacobwoffenden approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gary-H9 @jacobwoffenden