Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Add Egress S3 bucket to Analytical Platform Ingestion #5482

Merged
merged 11 commits into from
Mar 26, 2024
Merged

🔧 Add Egress S3 bucket to Analytical Platform Ingestion #5482

merged 11 commits into from
Mar 26, 2024

Conversation

Gary-H9
Copy link
Contributor

@Gary-H9 Gary-H9 commented Mar 26, 2024 •
edited
Loading

This PR adds:

  • S3 bucket
  • KMS key associated to the S3 bucket
  • Custom permissions to the KMS key which allow it to be called by the role in the analytical-platform-data-production account

@Gary-H9 Gary-H9 requested review from a team as code owners March 26, 2024 12:55
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Mar 26, 2024
@Gary-H9 Gary-H9 marked this pull request as draft March 26, 2024 12:56
@Gary-H9 Gary-H9 had a problem deploying to analytical-platform-ingestion-development March 26, 2024 12:57 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 14:35      — with 
GitHub Actions

                
    Failure


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 15:16      — with 
GitHub Actions

                
    Failure


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 15:31      — with 
GitHub Actions

                
    Failure


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 15:42      — with 
GitHub Actions

                
    Failure


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 15:52      — with 
GitHub Actions

                
    Failure


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 26, 2024 16:01      — with 
GitHub Actions

                
    Inactive


    










      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @Gary-H9
Gary-H9




        changed the title
Add S3 bucket to Ingestion

🔧  Add Egress S3 bucket to Analytical Platform Ingestion


      Mar 26, 2024

    

  








      

  
        





      

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 26, 2024 16:42      — with 
GitHub Actions

                
    Failure


    










      

  
        





      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 26, 2024 16:44      — with 
GitHub Actions

                
    Inactive


    










        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 26, 2024 16:59      — with 
GitHub Actions

                
    Inactive


    










        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          

  
  

  
      @Gary-H9
  Gary-H9


        marked this pull request as ready for review

    March 26, 2024 17:09    
    









        

  
        





        

  
        





        

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 26, 2024 17:14      — with 
GitHub Actions

                
    Inactive


    










        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          

  

    
  

  


        
        @Gary-H9
  Gary-H9



        merged commit dbd9134
      into

      
  
    main
  


    Mar 26, 2024

      

        12 checks passed
      


      

        
          
  
    
    

        
      

  







  

  
  

  
      @Gary-H9
  Gary-H9


    
    deleted the
    
      
        ingestion-s3
    
    branch

    March 26, 2024 17:16    
    




  

  

    
  


  

      

    @Gary-H9
Gary-H9



    mentioned this pull request
    
      Mar 26, 2024
    





  


  

      
  
  Closed

  





  
  

      
        
      
      

  
    
    
  


    4 tasks
  





  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @jacobwoffenden
  
    jacobwoffenden



          
            
              
            
          
          jacobwoffenden approved these changes

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    environments-repository

  Used to exclude PRs from this repo in our Slack PR update








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @Gary-H9 
        
          @jacobwoffenden