Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Create analytical-platform-ingestion #5419

Merged
merged 13 commits into from
Mar 20, 2024
Merged

🚀 Create analytical-platform-ingestion #5419

merged 13 commits into from
Mar 20, 2024

Conversation

Gary-H9
Copy link
Contributor

@Gary-H9 Gary-H9 commented Mar 20, 2024 •
edited by jacobwoffenden
Loading

This pull request:

  • Adds Analytical Platform's ingestion service, which is based on AWS Transfer Family

@Gary-H9 Gary-H9 requested review from a team as code owners March 20, 2024 11:02
@Gary-H9 Gary-H9 marked this pull request as draft March 20, 2024 11:02
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Mar 20, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Mar 20, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Mar 20, 2024
@modernisation-platform-ci

This comment was marked as off-topic.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
            

    

      
    

    


      

          @ministryofjustice
ministryofjustice




        deleted a comment from 
  github-actions bot


      Mar 20, 2024

    

  



    


    


    


    


    









        

  
            







        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        1 similar comment
      
    

  
    

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        

  

      

  davidkelliott
  

  
          

            
                  davidkelliott
  

            

            previously approved these changes


            
                
                  Mar 20, 2024
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  




  








        

  
          

  

  
  

  
      @jacobwoffenden
  jacobwoffenden


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 20, 2024 15:06      — with 
GitHub Actions

                
    Failure


    










        

  
        





        

  
          





        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        1 similar comment
      
    

  
    

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        

  

      

  dms1981
  

  
          

            
                  dms1981
  

            

            previously approved these changes


            
                
                  Mar 20, 2024
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  




  








        

  
          

  

  
  

  
      @Gary-H9
  Gary-H9


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 20, 2024 15:58      — with 
GitHub Actions

                
    Inactive


    










        

  
        





        

  
          





        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          

  

    
  


  

      

    @Gary-H9
Gary-H9



    mentioned this pull request
    
      Mar 20, 2024
    





  


  

      
  
  Closed

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  









        

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          

  
  

  
      @jacobwoffenden
  jacobwoffenden


        marked this pull request as ready for review

    March 20, 2024 16:27    
    









        

  
        





        

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@Gary-H9 Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
        





        

  
          

  

    
  

  


        
        @Gary-H9
  Gary-H9



        merged commit 06aee47
      into

      
  
    main
  


    Mar 20, 2024

      

        12 checks passed
      


      

        
          
  
    
    

        
      

  







  

  
  

  
      @Gary-H9
  Gary-H9


    
    deleted the
    
      
        ingestion
    
    branch

    March 20, 2024 16:56    
    











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @ASTRobinson
  
    ASTRobinson



          
            
              
            
          
          ASTRobinson approved these changes

        

        

          

  
      @jacobwoffenden
  
    jacobwoffenden



          
            
              
            
          
          jacobwoffenden approved these changes

        

        

          

  
      @davidkelliott
  
    davidkelliott



          
            
              
            
          
          davidkelliott left review comments

        

        

          

  
      @dms1981
  
    dms1981



          
            
              
            
          
          dms1981 left review comments

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    environments-repository

  Used to exclude PRs from this repo in our Slack PR update








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      6 participants
    

    

        
          @Gary-H9 
        
          @modernisation-platform-ci 
        
          @dms1981 
        
          @jacobwoffenden 
        
          @davidkelliott 
        
          @ASTRobinson