Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Extend Analytical Platform Ingestion's VPC #5400

Merged
merged 3 commits into from
Mar 18, 2024
Merged

🌐 Extend Analytical Platform Ingestion's VPC #5400

merged 3 commits into from
Mar 18, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Mar 18, 2024 •
edited
Loading

This pull request:

  • Extends the VPC to have public subnets and NAT gateway

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Switch to environment-configuration HCL
6c223aa 
Split out resources into files
Add public subnets and and NAT gateway

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Mar 18, 2024
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Mar 18, 2024
Remove locals.tf and update azs in vpc.tf
8240de5 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@github-actions GitHub Actions
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        1 similar comment
      
    

  
    

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














      

  
        

  

      

  
  

  
          

  

    

      


  

  




      

        
          oops
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          f357ec2
        
      

    

  

    

      
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>

    







  








      

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    











      

  
    

      
        1 similar comment
      
    

  
    

  
      



  

  @modernisation-platform-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














      

  
      



  

  @github-actions

    
      GitHub Actions
    




  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
TFSEC Scan Success


Show Output
```hcl



TFSEC will check the following folders:


</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:





CTFLint Scan Success


Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:




Trivy Scan


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
          

  

  
  

  
      @jacobwoffenden
  jacobwoffenden


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 18, 2024 12:04      — with 
GitHub Actions

                
    Failure


    





  

  

    
  


  

      

    @jacobwoffenden
jacobwoffenden



    mentioned this pull request
    
      Mar 18, 2024
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    4 tasks
  





  




  

  

  
  

  
      @jacobwoffenden
  jacobwoffenden


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 18, 2024 16:47      — with 
GitHub Actions

                
    Failure


    





  

  

  
  

  
      @jacobwoffenden
  jacobwoffenden


            had a problem deploying
      to
        analytical-platform-ingestion-development



    March 18, 2024 16:52      — with 
GitHub Actions

                
    Failure


    





  

  

  
  

  
      @jacobwoffenden
  jacobwoffenden


            temporarily deployed
      to
        analytical-platform-ingestion-development



    March 18, 2024 16:56      — with 
GitHub Actions

                
    Inactive


    










      

  
        

  

      

  ASTRobinson
  

  
          

            
                  ASTRobinson
  

            

            approved these changes


            
                
                  Mar 18, 2024
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      @ASTRobinson

      
            ASTRobinson
  

      

      

      left a comment




      
    


  



                    

                        

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

    

  
  




                      

                    
  

    
  
    
    

  

  




                        

                      
                    








      

  
  
  




  








      

  
          

  
  

  
      @jacobwoffenden
  jacobwoffenden


        marked this pull request as ready for review

    March 18, 2024 17:06    
    




  

  
  

  
      @jacobwoffenden
  jacobwoffenden


          requested review from
    a team

    as code owners


    March 18, 2024 17:06    
    




  

  

    
  

  


        
        @jacobwoffenden
  jacobwoffenden



        merged commit cf8a793
      into

      
  
    main
  


    Mar 18, 2024

      

        18 checks passed
      


      

        
          
  
    
    

        
      

  







  

  
  

  
      @jacobwoffenden
  jacobwoffenden


    
    deleted the
    
      
        feature/extend-ap-ingestion-vpc
    
    branch

    March 18, 2024 17:08    
    




  

  

    
  


  

      

    @jacobwoffenden
jacobwoffenden



    mentioned this pull request
    
      Mar 18, 2024
    





  


  

      
  
  Closed

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @ASTRobinson
  
    ASTRobinson



          
            
              
            
          
          ASTRobinson approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @jacobwoffenden
  
    jacobwoffenden
    

      








      


  


  

    Labels
  



    

      

    environments-repository

  Used to exclude PRs from this repo in our Slack PR update








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @jacobwoffenden 
        
          @modernisation-platform-ci 
        
          @ASTRobinson