Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomis: DSOS-2318: add textfile monitoring role #389

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

drobinson-moj
Copy link
Contributor

Added a separate role to handle nomis batch alerting (textfile monitoring)

Also couple of other things sneaked in:

  • Added a new type "exitcode" to more accurately reflect value of other metrics, e.g. 0=good, anything else error code
  • Simplified metric paths, e.g. all service checks are under the same metric name - we use dimension instance_type to differentiate between this. This allows us to use a single alarm to cover all services.

Tested on test-oem-a. I have separate ticket to roll out to all servers and adjust the Alarm definitions where appropriate.

@drobinson-moj drobinson-moj requested review from a team as code owners November 7, 2023 16:34
@drobinson-moj drobinson-moj merged commit d34a0f4 into main Nov 7, 2023
1 check passed
@drobinson-moj drobinson-moj deleted the nomis/DSOS-2318/add-textfile-monitoring-role branch November 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants