Linux AD Join Role Updates #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavmoj
commented
Oct 24, 2023
•
pavmoj
commented
- join-ad-linux role renamed to make it clearer which environment it is for
- Added prejoin / postjoin checks
- Removed hostname setting as this can be done elsewhere via group vars
- Removed ansible distribution to allow oracle linux distros to join also
- Added new ami tag role for hmpps domain services
pavmoj
force-pushed
the
feature/DSO-2206/test-join-ansible-role
branch
from
79bbb0a to
bb1ad7b
Compare
pavmoj
force-pushed
the
feature/DSO-2206/test-join-ansible-role
branch
from
689f66b to
96dcd21
Compare
robertsweetman
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.