Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomis: DSOS-2093: monitoring improvements v2 #368

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

drobinson-moj
Copy link
Contributor

@drobinson-moj drobinson-moj commented Oct 18, 2023

More tidy up of monitoring stuff as functionality was a bit muddled across roles

  • Add amazon-cloudwatch-agent-collectd role which enables cloudwatch to use collectd metrics. Puts the config in the correct place, no need to run ctl commands. Use handlers properly to reload service
  • Fixed selinux rules in collectd role. Removed the 5 minute wait for RHEL6. Only update if there has been a change.
  • Improved collectd-service-metrics which will monitor any service using whatever shell cmd you want. Removed the other crap in there like nomis monitoring. This will go elsewhere in a separate PR. Ensure the script is reloaded if there is a change.

Tested against RHEl6,7,8,OL8 and verified metrics with this code match the old code

@drobinson-moj drobinson-moj requested review from a team as code owners October 18, 2023 16:36
Copy link
Contributor

@jnqn jnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@drobinson-moj drobinson-moj merged commit 133c5d7 into main Oct 19, 2023
2 checks passed
@drobinson-moj drobinson-moj deleted the nomis/DSOS-2093/monitoring-improvements-v2 branch October 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants