AP-5608: Use moj design system interrupt #7553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add interrupt card styling from moj design system. Update page template helper to allow class to be added to page heading. Update view to use moj interrupt
Update to use govuk component for bullet lists and moj design system interrupt styling
agoldstone93
force-pushed
the
ap-5608-use-moj-design-system-interrupt
branch
from
6b572a8 to
0a6f35c
Compare
Remove div with class from start page which is in now deleted interrupt stylesheet. There are no obvious visual changes after deletion
|
colinbruce
approved these changes
Dec 30, 2024
| @@ -42,4 +42,4 @@ $govuk-assets-path: "/"; | |||
| @import "dropzone/src/dropzone"; | |||
| @import "dropzone/src/basic"; | |||
| @import "providers/summary_list_action_width"; | |||
| @import "primary_navigation"; | |||
| @import "primary_navigation"; | |||
There was a problem hiding this comment.
Missing blank line at end?
| continue_button_text: t("generic.continue"), | ||
| ) %> | ||
| <% end %> | ||
| <p class="govuk-body moj-interruption-card__body"><%= t(".body") %></p> |
There was a problem hiding this comment.
I assume you checked this split with design?
| <li><%= t(".use_service.sca_option") %></li> | ||
| <% end %> | ||
| </ul> | ||
| <p class="govuk-body"><%= t(".use_service.list_title") %></p> |
There was a problem hiding this comment.
This isn't interrupt related, right? I assume you started removing maximize-text-width and found another offender?
| <li><%= bullet %></li> | ||
| <% end %> | ||
| </ul> | ||
| <%= govuk_list list, type: :bullet, classes: "moj-interruption-card__body" %> |
There was a problem hiding this comment.
This could be a one-liner now there is a single impact
<%= govuk_list list, type: :bullet, classes: "moj-interruption-card__body" if local_assigns[:list] %>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Link to story
Checklist
Before you ask people to review this PR:
bundle exec rakegit rebase main.