-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP-4790: Update accessibility statement and change approach to translations for it #7548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsugarman
changed the title
AP-4790: Change approach to translation of Acceeesibility statement
AP-4790: Change approach to translation of Accessibility statement
Dec 18, 2024
jsugarman
force-pushed
the
ap-4790/update-accessibility-statement
branch
from
December 18, 2024 12:28
687461a
to
702502e
Compare
RoseSAK
approved these changes
Dec 18, 2024
jsugarman
force-pushed
the
ap-4790/update-accessibility-statement
branch
2 times, most recently
from
December 18, 2024 16:03
e204f2f
to
d115abe
Compare
jsugarman
changed the title
AP-4790: Change approach to translation of Accessibility statement
AP-4790: Update accessibility statement and change approach to translations for it
Dec 18, 2024
colinbruce
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
naseberry
reviewed
Dec 20, 2024
naseberry
approved these changes
Dec 20, 2024
Pending amendments to the accessibilty statement this removes the single accessibility view that uses separate translation files in favour of separate english and welsh views. This is because large [almost entirely] static html pages are more easily amended than calls to translation files, especially when we do not actually have any actual welsh translations.
This applies the main content changes for the accessibility statement but a few changes still required. 1. Number of days before response to queries is expected to have been supplied? 2. Confirm the WCAG standard tested against - should be 2.1 3. Confirm if truelayer still does not support internet explorer 11 - remove as not supported by MS or service either 4. Confirm if "out of scope" - add our exceptions see AP-4430/4439 3. Last updated date to be changed
- Correct WCAG version compliance - its 2.1 AA not 2.2. - Correct truelayer exception content. Not necessary to mentioned IE11 support as is generally not supported now
This is to cover remaining accessibility issues as noted by AP-4430 and AP-4439. See the examples on https://www.gov.uk/help/accessibility-statement.
Some final tweaks.
…ces section From or agreed with content designer
jsugarman
force-pushed
the
ap-4790/update-accessibility-statement
branch
from
December 20, 2024 11:09
7c41cb1
to
c73e90d
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update accessibility statement and change approach to translations
Link to story
Following handling of user accessibility report we need to update the
accessibiility statement.
This also changes the approach for rendering the accessibility statement
from using a single view that uses separate translation files in favour of
separate english and welsh views. This is because large [almost entirely]
static html pages are more easily amended than calls to translation files,
especially when we do not actually have any actual welsh translations.
TODO
Checklist
Before you ask people to review this PR:
bundle exec rake
git rebase main
.