Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4790: Update accessibility statement and change approach to translations for it #7548

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Dec 18, 2024

What

Update accessibility statement and change approach to translations

Link to story

Following handling of user accessibility report we need to update the
accessibiility statement.

This also changes the approach for rendering the accessibility statement
from using a single view that uses separate translation files in favour of
separate english and welsh views. This is because large [almost entirely]
static html pages are more easily amended than calls to translation files,
especially when we do not actually have any actual welsh translations.

TODO

  • change approach to translations
  • update statement
  • Add number of days for response times
  • Look at amending content for "Content that’s not within the scope of the accessibility regulations"

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman changed the title AP-4790: Change approach to translation of Acceeesibility statement AP-4790: Change approach to translation of Accessibility statement Dec 18, 2024
@jsugarman jsugarman force-pushed the ap-4790/update-accessibility-statement branch from 687461a to 702502e Compare December 18, 2024 12:28
@jsugarman jsugarman force-pushed the ap-4790/update-accessibility-statement branch 2 times, most recently from e204f2f to d115abe Compare December 18, 2024 16:03
@jsugarman jsugarman changed the title AP-4790: Change approach to translation of Accessibility statement AP-4790: Update accessibility statement and change approach to translations for it Dec 18, 2024
@jsugarman jsugarman assigned jsugarman and unassigned jsugarman Dec 20, 2024
@jsugarman jsugarman added the ready for review Please review label Dec 20, 2024
@jsugarman jsugarman marked this pull request as ready for review December 20, 2024 10:04
@jsugarman jsugarman requested a review from a team as a code owner December 20, 2024 10:04
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pending amendments to the accessibilty statement this removes the single
accessibility view that uses separate translation files in favour of
separate english and welsh views. This is because large [almost entirely]
static html pages are more easily amended than calls to translation files,
especially when we do not actually have any actual welsh translations.
This applies the main content changes for the accessibility statement but
a few changes still required.

1. Number of days before response to queries is expected to have been supplied?
2. Confirm the WCAG standard tested against - should be 2.1
3. Confirm if truelayer still does not support internet explorer 11 - remove as not supported by MS or service either
4. Confirm if "out of scope" - add our exceptions see AP-4430/4439
3. Last updated date to be changed
- Correct WCAG version compliance - its 2.1 AA not 2.2.
- Correct truelayer exception content. Not necessary to
  mentioned IE11 support as is generally not supported now
This is to cover remaining accessibility issues as
noted by AP-4430 and AP-4439. See the examples
on https://www.gov.uk/help/accessibility-statement.
…ces section

From or agreed with content designer
@jsugarman jsugarman force-pushed the ap-4790/update-accessibility-statement branch from 7c41cb1 to c73e90d Compare December 20, 2024 11:09
@jsugarman jsugarman merged commit 0c5d8f4 into main Dec 20, 2024
15 checks passed
@jsugarman jsugarman deleted the ap-4790/update-accessibility-statement branch December 20, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants