AP-5592: Update scope limits on check provider answers #7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinbruce
force-pushed
the
ap-5592/cya-provider-scope-limits
branch
9 times, most recently
from
d843e30 to
8caa09a
Compare
jsugarman
approved these changes
Dec 17, 2024
| @@ -21,10 +21,16 @@ def scope_limits(proceeding, scope_type) | |||
| private | |||
|
|
|||
| def scope_limitation_details(scope_limitation) | |||
| scope_limitation_details = [scope_limitation.meaning, scope_limitation.description] | |||
| sole_scope_limitation = scope_limitation.proceeding.scope_limitations.where(scope_type: scope_limitation.scope_type).count.eql?(1) | |||
There was a problem hiding this comment.
Could extract to own method
def sole_scope_limitation?(scope_limitation)
scope_limitation.proceeding.scope_limitations.where(scope_type: scope_limitation.scope_type).count.eql?(1)
end
Comment on lines
+25
to
+30
| scope_limitation_meaning = if sole_scope_limitation | ||
| scope_limitation.meaning | ||
| else | ||
| "<span class=\"single-scope-limit-heading\">#{scope_limitation.meaning}</span>".html_safe | ||
| end | ||
| scope_limitation_details = [scope_limitation_meaning, scope_limitation.description] |
There was a problem hiding this comment.
another method extraction perhaps?
def scope_limitation_base_details(scope_limitation)
scope_limitation_meaning = if sole_scope_limitation?(scope_limitation)
scope_limitation.meaning
else
"<span class=\"single-scope-limit-heading\">#{scope_limitation.meaning}</span>".html_safe
end
[scope_limitation_meaning, scope_limitation.description]
endThere was a problem hiding this comment.
or extract both to a class nested in the helper?
like...
ScopeLimitationDetailBuilder.new(scope_limitation).call
This changes the proceeding_details partial IDs quite heavily to make testing easier.
Add the date to the end of the description if has not been added by the proceeding method. This is needed to remove the duplication of date values on the check your answer pages This may be a temp fix while scope limitation texts are reviewed
Rather than downcase each interpolated value, downcase the entire selector name
allow both upper and lower case emeregency or substantive types to be passed this allows a more uniform appearance in the the feature test scenarios
colinbruce
force-pushed
the
ap-5592/cya-provider-scope-limits
branch
from
002d3e1 to
f43e70e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Link to story
This PR changes the proceeding_details partial IDs quite heavily to make testing easier.
Update the proceeding_helper to display the new logic required
Checklist
Before you ask people to review this PR:
bundle exec rakegit rebase main.